Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 28923006: Roll libphonenumber to r621. (Closed)

Created:
7 years, 2 months ago by Philippe
Modified:
6 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Philippe
Hi Nico, This rolls libphonenumber. I'm not super familiar with updating the perf expectations. Would ...
7 years, 2 months ago (2013-10-21 13:51:45 UTC) #1
Nico
Lgtm, thanks! Optional: add a BUG line for the static initializer bug. I'll handle the ...
7 years, 2 months ago (2013-10-21 13:54:53 UTC) #2
Philippe
Thanks Nico!
7 years, 2 months ago (2013-10-21 13:58:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/28923006/270001
7 years, 2 months ago (2013-10-21 13:59:37 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=91169
7 years, 2 months ago (2013-10-21 20:24:49 UTC) #5
Nico
Committed patchset #2 manually as r229898.
7 years, 2 months ago (2013-10-21 20:27:36 UTC) #6
tamutharlay
6 years, 1 month ago (2014-11-20 00:42:58 UTC) #7
Message was sent while issue was closed.
On 2013/10/21 20:27:36, Nico wrote:
> Committed patchset #2 manually as r229898.

 #2 manually as r229898.

Powered by Google App Engine
This is Rietveld 408576698