DevTools: console.table attached inside a collapsed console group is not resizeable.

DevTools: console.table attached inside a collapsed console group is not resizeable.

A DataGrid being attached to a hidden parent (e.g. collapsed console group) can not
initialize column widths right away and just skips it. And it will never do so
unless explicitly asked. Thus the problem happens when the parent becomes visible.

To overcome this we call wasShown() for console messages and groups recursively.

BUG=306120
R=pfeldman,vsevik,eustas@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160457

[aandrey, 2013-10-22 10:28:54]

ping

[pfeldman, 2013-10-22 10:39:47]

I think I was fixing it differently. Lets chat.

[aandrey, 2013-10-22 13:46:57]

On 2013/10/22 10:39:47, pfeldman wrote:
> I think I was fixing it differently. Lets chat.

Removed the mousemove hack. Now calling wasShown() explicitly from ConsoleGroup.

[pfeldman, 2013-10-23 13:05:38]

https://codereview.chromium.org/28923003/diff/130001/Source/devtools/front_en...
File Source/devtools/front_end/DOMExtension.js (right):

https://codereview.chromium.org/28923003/diff/130001/Source/devtools/front_en...
Source/devtools/front_end/DOMExtension.js:197: return
this.classList.toggle(className);
Lets use classList, we already use it for multiple classes. We can migrate the
whole source base to it actually.

https://codereview.chromium.org/28923003/diff/130001/Source/devtools/front_en...
File Source/devtools/front_end/DataGrid.js (right):

https://codereview.chromium.org/28923003/diff/130001/Source/devtools/front_en...
Source/devtools/front_end/DataGrid.js:584: var tableWidth =
this._dataTable.offsetWidth;
When grid only has header and no elements, this is 0, while
this.element.offsetWidth is not. Or am I wrong?

https://codereview.chromium.org/28923003/diff/130001/Source/devtools/front_en...
Source/devtools/front_end/DataGrid.js:596: var percentWidth = (100 * columnWidth
/ tableWidth) + "%";
Why?

[aandrey, 2013-10-23 13:35:59]

https://codereview.chromium.org/28923003/diff/130001/Source/devtools/front_en...
File Source/devtools/front_end/DOMExtension.js (right):

https://codereview.chromium.org/28923003/diff/130001/Source/devtools/front_en...
Source/devtools/front_end/DOMExtension.js:197: return
this.classList.toggle(className);
On 2013/10/23 13:05:38, pfeldman wrote:
> Lets use classList, we already use it for multiple classes. We can migrate the
> whole source base to it actually.

Done.

https://codereview.chromium.org/28923003/diff/130001/Source/devtools/front_en...
File Source/devtools/front_end/DataGrid.js (right):

https://codereview.chromium.org/28923003/diff/130001/Source/devtools/front_en...
Source/devtools/front_end/DataGrid.js:584: var tableWidth =
this._dataTable.offsetWidth;
On 2013/10/23 13:05:38, pfeldman wrote:
> When grid only has header and no elements, this is 0, while
> this.element.offsetWidth is not. Or am I wrong?

Reverted.

https://codereview.chromium.org/28923003/diff/130001/Source/devtools/front_en...
Source/devtools/front_end/DataGrid.js:596: var percentWidth = (100 * columnWidth
/ tableWidth) + "%";
On 2013/10/23 13:05:38, pfeldman wrote:
> Why?

An (poor) attempt to get more precision in floating point math.
Did not help in my particular tests, but does not make things worse.

FYI. Sometimes I observed off-by-1px size glitches while resizing.

[pfeldman, 2013-10-24 14:40:41]

lgtm

https://codereview.chromium.org/28923003/diff/170001/Source/devtools/front_en...
File Source/devtools/front_end/DataGrid.js (right):

https://codereview.chromium.org/28923003/diff/170001/Source/devtools/front_en...
Source/devtools/front_end/DataGrid.js:1082: var percentLeftColumn = (100 *
(dragPoint - leftEdgeOfPreviousColumn) / tableWidth) + "%";
I don't think floating point precision matters since we map it to pixels in the
end.

[commit-bot: I haz the power, 2013-10-24 14:41:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aandrey@chromium.org/28923003/170001

[commit-bot: I haz the power, 2013-10-24 15:43:38]

Change committed as 160457