Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: Source/devtools/front_end/ConsoleView.js

Issue 28923003: DevTools: console.table attached inside a collapsed console group is not resizeable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/ConsoleView.js
diff --git a/Source/devtools/front_end/ConsoleView.js b/Source/devtools/front_end/ConsoleView.js
index c0ec686c9e932dadb06bbdbf4e8830366a6ebe59..87e0aec78ace4963226c563538437daac97863ce 100644
--- a/Source/devtools/front_end/ConsoleView.js
+++ b/Source/devtools/front_end/ConsoleView.js
@@ -1227,15 +1227,28 @@ WebInspector.ConsoleGroup.prototype = {
var groupTitleElement = event.target.enclosingNodeOrSelfWithClass("console-group-title");
if (groupTitleElement) {
var groupElement = groupTitleElement.enclosingNodeOrSelfWithClass("console-group");
- if (groupElement)
- if (groupElement.hasStyleClass("collapsed"))
- groupElement.removeStyleClass("collapsed");
- else
- groupElement.addStyleClass("collapsed");
+ if (groupElement && !groupElement.classList.toggle("collapsed")) {
+ if (groupElement.group) {
+ groupElement.group.wasShown();
+ }
+ }
groupTitleElement.scrollIntoViewIfNeeded(true);
}
-
event.consume(true);
+ },
+
+ wasShown: function()
+ {
+ if (this.element.hasStyleClass("collapsed"))
+ return;
+ var node = this.messagesElement.firstChild;
+ while (node) {
+ if (node.hasStyleClass("console-message") && node.message)
+ node.message.wasShown();
+ if (node.hasStyleClass("console-group") && node.group)
+ node.group.wasShown();
+ node = node.nextSibling;
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698