Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1414)

Unified Diff: third_party/WebKit/Source/web/WebAXObject.cpp

Issue 2892283002: Speculative fix for crasher. (Closed)
Patch Set: Add TODO's Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebAXObject.cpp
diff --git a/third_party/WebKit/Source/web/WebAXObject.cpp b/third_party/WebKit/Source/web/WebAXObject.cpp
index b2082cd383b44a735b037a7598a7e245463bdce0..12d9a6d202cc459b5c81295d43d16515f1412653 100644
--- a/third_party/WebKit/Source/web/WebAXObject.cpp
+++ b/third_party/WebKit/Source/web/WebAXObject.cpp
@@ -160,7 +160,9 @@ int WebAXObject::GenerateAXID() const {
bool WebAXObject::UpdateLayoutAndCheckValidity() {
if (!IsDetached()) {
Document* document = private_->GetDocument();
- if (!document || !document->View())
+ // TODO(szager): Investigate whether/why document->IsDetached() can be
+ // true when this->IsDetached() is false.
+ if (!document || !document->View() || document->IsDetached())
return false;
document->View()->UpdateLifecycleToCompositingCleanPlusScrolling();
}
« no previous file with comments | « third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698