Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2892283002: Speculative fix for crasher. (Closed)

Created:
3 years, 7 months ago by szager1
Modified:
3 years, 7 months ago
Reviewers:
pdr., szager, skobes, dmazzoni
CC:
aboxhall, blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, dmazzoni, dougt+watch_chromium.org, je_julie, kinuko+watch, nektarios
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative fix for crasher. I speculate that WebAXObject::IsDetached() may not be as reliable as Document::IsDetached(). Also, add a SECURITY_CHECK in the place where I suspect the bad access is happening. BUG=722801 R=dmazzoni@chromium.org,skobes@chromium.org Review-Url: https://codereview.chromium.org/2892283002 Cr-Commit-Position: refs/heads/master@{#473448} Committed: https://chromium.googlesource.com/chromium/src/+/fc9849ac4fd3411fe46254ab10405d7ceae0a5b6

Patch Set 1 #

Total comments: 6

Patch Set 2 : s/SECURITY_CHECK/CHECK/ #

Patch Set 3 : Add TODO's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 23 (9 generated)
szager1
3 years, 7 months ago (2017-05-19 22:11:05 UTC) #1
skobes
lgtm
3 years, 7 months ago (2017-05-19 22:30:57 UTC) #2
szager
+pdr for web/OWNERS
3 years, 7 months ago (2017-05-19 22:44:59 UTC) #6
pdr.
https://codereview.chromium.org/2892283002/diff/1/third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp File third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp (right): https://codereview.chromium.org/2892283002/diff/1/third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp#newcode18 third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp:18: SECURITY_CHECK(frame_view); Is this actually related to security? If not, ...
3 years, 7 months ago (2017-05-19 22:47:50 UTC) #7
szager
https://codereview.chromium.org/2892283002/diff/1/third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp File third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp (right): https://codereview.chromium.org/2892283002/diff/1/third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp#newcode18 third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp:18: SECURITY_CHECK(frame_view); On 2017/05/19 22:47:50, pdr. wrote: > Is this ...
3 years, 7 months ago (2017-05-19 22:52:39 UTC) #8
dcheng
drive-bys https://codereview.chromium.org/2892283002/diff/1/third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp File third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp (right): https://codereview.chromium.org/2892283002/diff/1/third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp#newcode18 third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp:18: SECURITY_CHECK(frame_view); On 2017/05/19 22:47:50, pdr. wrote: > Is ...
3 years, 7 months ago (2017-05-19 22:55:08 UTC) #9
szager
https://codereview.chromium.org/2892283002/diff/1/third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp File third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp (right): https://codereview.chromium.org/2892283002/diff/1/third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp#newcode18 third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp:18: SECURITY_CHECK(frame_view); On 2017/05/19 22:55:08, dcheng (in AEST) wrote: > ...
3 years, 7 months ago (2017-05-19 23:04:40 UTC) #10
pdr.
I just loaded the minidump in a debugger and frame_view is definitely null. Do we ...
3 years, 7 months ago (2017-05-19 23:14:03 UTC) #11
szager
On 2017/05/19 23:14:03, pdr. wrote: > I just loaded the minidump in a debugger and ...
3 years, 7 months ago (2017-05-19 23:24:33 UTC) #12
pdr.
On 2017/05/19 at 23:24:33, szager wrote: > On 2017/05/19 23:14:03, pdr. wrote: > > I ...
3 years, 7 months ago (2017-05-19 23:31:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892283002/40001
3 years, 7 months ago (2017-05-20 00:23:57 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/298809)
3 years, 7 months ago (2017-05-20 03:46:09 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892283002/40001
3 years, 7 months ago (2017-05-20 19:48:16 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-20 20:24:41 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fc9849ac4fd3411fe46254ab1040...

Powered by Google App Engine
This is Rietveld 408576698