Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: third_party/WebKit/Source/web/WebAXObject.cpp

Issue 2892283002: Speculative fix for crasher. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebAXObject.cpp
diff --git a/third_party/WebKit/Source/web/WebAXObject.cpp b/third_party/WebKit/Source/web/WebAXObject.cpp
index b2082cd383b44a735b037a7598a7e245463bdce0..ca4f1a95eb5321ebe3165dbcfc89d22665d94211 100644
--- a/third_party/WebKit/Source/web/WebAXObject.cpp
+++ b/third_party/WebKit/Source/web/WebAXObject.cpp
@@ -160,7 +160,7 @@ int WebAXObject::GenerateAXID() const {
bool WebAXObject::UpdateLayoutAndCheckValidity() {
if (!IsDetached()) {
Document* document = private_->GetDocument();
- if (!document || !document->View())
+ if (!document || !document->View() || document->IsDetached())
dcheng 2017/05/19 22:55:08 Can we add a TODO for accessibility to see if we c
szager 2017/05/19 23:04:40 Done.
return false;
document->View()->UpdateLifecycleToCompositingCleanPlusScrolling();
}

Powered by Google App Engine
This is Rietveld 408576698