Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2892273002: Remove duplicate service worker "CSP" tests (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate service worker "register" tests This tests are identical to the versions available in the Web Platform Tests project and may therefore be removed without impacting coverage. BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2892273002 Cr-Commit-Position: refs/heads/master@{#473590} Committed: https://chromium.googlesource.com/chromium/src/+/a3807a414df426f04aa8241cba28a39cbe834eab

Patch Set 1 #

Messages

Total messages: 8 (4 generated)
mike3
Hi Matt, The equivalence of these tests is a little harder to appreciate than most ...
3 years, 7 months ago (2017-05-19 21:49:42 UTC) #2
falken
lgtm
3 years, 7 months ago (2017-05-22 04:36:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892273002/1
3 years, 7 months ago (2017-05-22 14:46:02 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 16:22:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a3807a414df426f04aa8241cba28...

Powered by Google App Engine
This is Rietveld 408576698