extensions/renderer/resources/guest_view/guest_view.js - Issue 2892253002: Fix for GuestView exposure through shift().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/guest_view.js

Issue 2892253002: Fix for GuestView exposure through shift(). (Closed)

Patch Set: Removed WeakPtr from this patch. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/resources/guest_view/guest_view.js

diff --git a/extensions/renderer/resources/guest_view/guest_view.js b/extensions/renderer/resources/guest_view/guest_view.js

index c228dca09aa731c92a5e87f58a212271a5be1812..25dc651008737f2505321532d11c0f2b26947426 100644

--- a/extensions/renderer/resources/guest_view/guest_view.js

+++ b/extensions/renderer/resources/guest_view/guest_view.js

@@ -94,7 +94,7 @@ GuestViewImpl.prototype.performNextAction = function() {

// Make sure that there is not already an action in progress, and that there

// exists a queued action to perform.

if (!this.pendingAction && this.actionQueue.length) {

- this.pendingAction = this.actionQueue.shift();

+ this.pendingAction = $Array.shift(this.actionQueue);

this.pendingAction();

}

};