Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: extensions/renderer/resources/guest_view/extension_view/extension_view.js

Issue 2892253002: Fix for GuestView exposure through shift(). (Closed)
Patch Set: Removed WeakPtr from this patch. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/resources/guest_view/guest_view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/guest_view/extension_view/extension_view.js
diff --git a/extensions/renderer/resources/guest_view/extension_view/extension_view.js b/extensions/renderer/resources/guest_view/extension_view/extension_view.js
index 967839e075d967caa787bd3e02f080a4490edf1f..f28bf6d17c18d12b4e12eba1dbdc169dd6c7fdd2 100644
--- a/extensions/renderer/resources/guest_view/extension_view/extension_view.js
+++ b/extensions/renderer/resources/guest_view/extension_view/extension_view.js
@@ -71,7 +71,7 @@ ExtensionViewImpl.prototype.loadNextSrc = function() {
// If extensionview isn't currently loading a src, load the next src
// in |loadQueue|. Otherwise, do nothing.
if (!this.pendingLoad && this.loadQueue.length) {
- this.pendingLoad = this.loadQueue.shift();
+ this.pendingLoad = $Array.shift(this.loadQueue);
var src = this.pendingLoad.src;
var resolve = this.pendingLoad.resolve;
var reject = this.pendingLoad.reject;
« no previous file with comments | « no previous file | extensions/renderer/resources/guest_view/guest_view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698