Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2892203002: Android UrlBar: Fix scrolling to most-significant part of RTL domains. (Closed)

Created:
3 years, 7 months ago by tommycli
Modified:
3 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android UrlBar: Fix scrolling to most-significant part of RTL domains. Fix isn't perfect. See the comment and bug, but it's decent. BUG=723100 Review-Url: https://codereview.chromium.org/2892203002 Cr-Commit-Position: refs/heads/master@{#473269} Committed: https://chromium.googlesource.com/chromium/src/+/d5a340817ee90fb66e5e23316311987e8f92e1ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
tommycli
tedchoc: PTAL. This seems to work. (See screenshots in bug). I /think/ I know what's ...
3 years, 7 months ago (2017-05-19 18:04:02 UTC) #2
Ted C
On 2017/05/19 18:04:02, tommycli wrote: > tedchoc: PTAL. This seems to work. (See screenshots in ...
3 years, 7 months ago (2017-05-19 18:42:03 UTC) #5
tommycli
On 2017/05/19 18:42:03, Ted C wrote: > On 2017/05/19 18:04:02, tommycli wrote: > > tedchoc: ...
3 years, 7 months ago (2017-05-19 19:04:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892203002/1
3 years, 7 months ago (2017-05-19 19:06:45 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 19:12:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5a340817ee90fb66e5e23316311...

Powered by Google App Engine
This is Rietveld 408576698