Android UrlBar: Fix scrolling to most-significant part of RTL domains.

Android UrlBar: Fix scrolling to most-significant part of RTL domains.

Fix isn't perfect. See the comment and bug, but it's decent.

BUG=723100
Review-Url: https://codereview.chromium.org/2892203002
Cr-Commit-Position: refs/heads/master@{#473269}
Committed: https://chromium.googlesource.com/chromium/src/+/d5a340817ee90fb66e5e23316311987e8f92e1ee

[tommycli, 2017-05-19 18:04:01]

tommycli@chromium.org changed reviewers:
+ tedchoc@chromium.org

[tommycli, 2017-05-19 18:04:02]

tedchoc: PTAL. This seems to work. (See screenshots in bug).

I /think/ I know what's going on now (see last comment by me in bug), but please
scrutinize my reasoning.

Thank you!

Tommy

[tommycli, 2017-05-19 18:10:40]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 18:11:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ted C, 2017-05-19 18:42:03]

On 2017/05/19 18:04:02, tommycli wrote:
> tedchoc: PTAL. This seems to work. (See screenshots in bug).
> 
> I /think/ I know what's going on now (see last comment by me in bug), but
please
> scrutinize my reasoning.
> 
> Thank you!
> 
> Tommy

lgtm! ... makes sense to me.  I had issues where bringPointIntoView had
weird timing issues, but if you're not seeing that then this definitely is
making it better (and likely fixes some other bugs where if you went from
a long url to a short one then the setSelection call wouldn't actually
move it forward to show the full domain).

If you have other android versions available, it would be good to
test on older ones, but yeah...awesome investigation and findings!

[tommycli, 2017-05-19 19:04:26]

On 2017/05/19 18:42:03, Ted C wrote:
> On 2017/05/19 18:04:02, tommycli wrote:
> > tedchoc: PTAL. This seems to work. (See screenshots in bug).
> > 
> > I /think/ I know what's going on now (see last comment by me in bug), but
> please
> > scrutinize my reasoning.
> > 
> > Thank you!
> > 
> > Tommy
> 
> lgtm! ... makes sense to me.  I had issues where bringPointIntoView had
> weird timing issues, but if you're not seeing that then this definitely is
> making it better (and likely fixes some other bugs where if you went from
> a long url to a short one then the setSelection call wouldn't actually
> move it forward to show the full domain).
> 
> If you have other android versions available, it would be good to
> test on older ones, but yeah...awesome investigation and findings!

I did see that bringPointIntoView can sometimes be deferred (with negative
results) if a layout has already been requested -- I'm guessing those would be
the timing issues you described.

I didn't see this happen on either Android 5.1 or 7.1. I'll send this in and
give it a try.

[tommycli, 2017-05-19 19:06:00]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-05-19 19:06:01]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-05-19 19:06:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 19:12:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495220761121730, "parent_rev":
"420cf37ad0ddf1c54203a4fdffb68af920503b0e", "commit_rev":
"d5a340817ee90fb66e5e23316311987e8f92e1ee"}

[commit-bot: I haz the power, 2017-05-19 19:12:23]

Description was changed from

==========
Android UrlBar: Fix scrolling to most-significant part of RTL domains.

Fix isn't perfect. See the comment and bug, but it's decent.

BUG=723100
==========

to

==========
Android UrlBar: Fix scrolling to most-significant part of RTL domains.

Fix isn't perfect. See the comment and bug, but it's decent.

BUG=723100

Review-Url: https://codereview.chromium.org/2892203002
Cr-Commit-Position: refs/heads/master@{#473269}
Committed:
https://chromium.googlesource.com/chromium/src/+/d5a340817ee90fb66e5e23316311...
==========

[commit-bot: I haz the power, 2017-05-19 19:12:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5a340817ee90fb66e5e23316311...