Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2892153003: Add jgruber@ to src/js/OWNERS (Closed)

Created:
3 years, 7 months ago by jgruber
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer, adamk, Yang
CC:
v8-reviews_googlegroups.com, adamk, Camillo Bruni, Igor Sheludko, Jakob Kummerow, Dan Ehrenberg, rossberg, Toon Verwaest
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Add jgruber@ to src/js/OWNERS BUG= Review-Url: https://codereview.chromium.org/2892153003 Cr-Commit-Position: refs/heads/master@{#45442} Committed: https://chromium.googlesource.com/v8/v8/+/897c2ca3311f937df40c45d0dced259b53404584

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/js/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
jgruber
Hi folks (+cc all src/js owners), I propose adding myself to src/js owners. I've been ...
3 years, 7 months ago (2017-05-19 08:47:54 UTC) #4
Benedikt Meurer
LGTM
3 years, 7 months ago (2017-05-19 08:53:11 UTC) #5
adamk
lgtm
3 years, 7 months ago (2017-05-19 17:06:45 UTC) #9
Yang
On 2017/05/19 17:06:45, adamk wrote: > lgtm lgtm
3 years, 7 months ago (2017-05-19 19:28:09 UTC) #10
Yang
On 2017/05/19 17:06:45, adamk wrote: > lgtm lgtm
3 years, 7 months ago (2017-05-19 19:28:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892153003/1
3 years, 7 months ago (2017-05-22 06:32:50 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 06:55:12 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/897c2ca3311f937df40c45d0dced259b534...

Powered by Google App Engine
This is Rietveld 408576698