Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2892143002: Remove all feature flag checks in Delegate. (Closed)

Created:
3 years, 7 months ago by Leo
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all feature flag checks in Delegate. BUG=703887 Review-Url: https://codereview.chromium.org/2892143002 Cr-Commit-Position: refs/heads/master@{#474123} Committed: https://chromium.googlesource.com/chromium/src/+/31d4ea1da777afb9e583464b0149124df5ecec3b

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M chrome/browser/ui/android/infobars/translate_compact_infobar.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/translate_infobar.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/translate/core/browser/translate_infobar_delegate.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M components/translate/core/browser/translate_infobar_delegate.cc View 1 3 chunks +4 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
Leo
3th CL from the code cleanup. Used to clear all flag checks in Delegate.
3 years, 7 months ago (2017-05-19 07:21:10 UTC) #3
napper
lgtm https://codereview.chromium.org/2892143002/diff/1/components/translate/core/browser/translate_infobar_delegate.cc File components/translate/core/browser/translate_infobar_delegate.cc (right): https://codereview.chromium.org/2892143002/diff/1/components/translate/core/browser/translate_infobar_delegate.cc#newcode386 components/translate/core/browser/translate_infobar_delegate.cc:386: bool declined = responder_ const bool
3 years, 7 months ago (2017-05-19 23:01:31 UTC) #4
groby-ooo-7-16
lgtm
3 years, 7 months ago (2017-05-20 03:34:48 UTC) #5
Leo
+mdjones@chromium.org for infobar part ownership.
3 years, 7 months ago (2017-05-23 04:42:29 UTC) #7
mdjones
lgtm
3 years, 7 months ago (2017-05-23 17:19:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892143002/20001
3 years, 7 months ago (2017-05-23 22:51:27 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 00:35:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/31d4ea1da777afb9e583464b0149...

Powered by Google App Engine
This is Rietveld 408576698