Make snackbar on tablet center aligned and sticked to bottom.

Make snackbar on tablet center aligned and sticked to bottom.
Currently, snackbar on tablet are left aligned and farther from bottom.
It doesn't look nice with the infobar which is center aligned.

Below is what the snackbar looks like on tablet after the change:
https://drive.google.com/open?id=0B1O0Z7eoZMuGT1NPcEhKb2VwdWM

BUG=723200
Review-Url: https://codereview.chromium.org/2892133002
Cr-Commit-Position: refs/heads/master@{#473583}
Committed: https://chromium.googlesource.com/chromium/src/+/693c21e381f14e84e67137c2307e1c83a24923fe

[Marti Wong, 2017-05-19 05:10:51]

martiw@chromium.org changed reviewers:
+ twellington@chromium.org

[Marti Wong, 2017-05-19 05:10:52]

Hi Theresa, PTAL.
Thanks so much!

https://codereview.chromium.org/2892133002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java
(right):

https://codereview.chromium.org/2892133002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java:156:
lp.gravity = Gravity.CENTER_HORIZONTAL | Gravity.BOTTOM;
There is another approach to this CL:

No need to change all MarginLayoutParams to FrameLayout.
And just put the follow line here for the center alignment:
ApiCompatibilityUtils.setMarginStart(lp, (mParent.getWidth() - lp.width) / 2);

That approach is less risky but looks too hacky.
So I end up using FrameLayout.

[Marti Wong, 2017-05-19 06:00:39]

Description was changed from

==========
Make snackbar on tablet center aligned and sticked to bottom.
Currently, snackbar on tablet are left aligned and farther from bottom.
It doesn't look nice with the infobar which is center aligned.

Below is what the snackbar looks like on tablet after the change:
https://drive.google.com/open?id=0B1O0Z7eoZMuGT1NPcEhKb2VwdWM

BUG=723200
==========

to

==========
Make snackbar on tablet center aligned and sticked to bottom.
Currently, snackbar on tablet are left aligned and farther from bottom.
It doesn't look nice with the infobar which is center aligned.

Below is what the snackbar looks like on tablet after the change:
https://drive.google.com/open?id=0B1O0Z7eoZMuGT1NPcEhKb2VwdWM

BUG=723200
==========

[Marti Wong, 2017-05-19 06:00:40]

martiw@chromium.org changed reviewers:
+ ramyasharma@chromium.org

[Marti Wong, 2017-05-19 06:30:41]

Hi Theresa,
I just realized that you are not one of the owners of this file.
Please feel free to assign this to other.
By the way, do you think I need PM approval of something for this one?
Thanks,
Marti


On 2017/05/19 05:10:52, Marti Wong wrote:
> Hi Theresa, PTAL.
> Thanks so much!
> 
>
https://codereview.chromium.org/2892133002/diff/1/chrome/android/java/src/org...
> File
> chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java
> (right):
> 
>
https://codereview.chromium.org/2892133002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java:156:
> lp.gravity = Gravity.CENTER_HORIZONTAL | Gravity.BOTTOM;
> There is another approach to this CL:
> 
> No need to change all MarginLayoutParams to FrameLayout.
> And just put the follow line here for the center alignment:
> ApiCompatibilityUtils.setMarginStart(lp, (mParent.getWidth() - lp.width) / 2);
> 
> That approach is less risky but looks too hacky.
> So I end up using FrameLayout.

[Theresa, 2017-05-19 17:25:48]

I'll do the initial review and then we can loop in an OWNER for approval.

The FrameLayout approach looks good! The designers indicated that they'd like to
remove the rounded corners on the bottom. We can edit
chrome/android/java/res/drawable/snackbar_background_tablet.xml. If we replace
android:radius with android:topLeftRadius and android:topRightRadius, that
should remove the rounded corners on the bottom.

[Ted C, 2017-05-19 17:43:34]

On 2017/05/19 17:25:48, Theresa wrote:
> I'll do the initial review and then we can loop in an OWNER for approval.
> 
> The FrameLayout approach looks good! The designers indicated that they'd like
to
> remove the rounded corners on the bottom. We can edit
> chrome/android/java/res/drawable/snackbar_background_tablet.xml. If we replace
> android:radius with android:topLeftRadius and android:topRightRadius, that
> should remove the rounded corners on the bottom.

I've solved the glitch:
https://codereview.chromium.org/2891223003/

[Marti Wong, 2017-05-20 08:37:35]

Hi Theresa and Ted,
Thanks for the help~!
Rounded corners on the bottom removed.
PTAL.

[Theresa, 2017-05-22 15:07:03]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2017-05-22 15:07:03]

lgtm

[commit-bot: I haz the power, 2017-05-22 15:07:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 15:45:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495465623141180,
"parent_rev": "f72054ceedbf07e177d5b740aca7a2c196f9be46", "commit_rev":
"693c21e381f14e84e67137c2307e1c83a24923fe"}

[commit-bot: I haz the power, 2017-05-22 15:46:03]

Description was changed from

==========
Make snackbar on tablet center aligned and sticked to bottom.
Currently, snackbar on tablet are left aligned and farther from bottom.
It doesn't look nice with the infobar which is center aligned.

Below is what the snackbar looks like on tablet after the change:
https://drive.google.com/open?id=0B1O0Z7eoZMuGT1NPcEhKb2VwdWM

BUG=723200
==========

to

==========
Make snackbar on tablet center aligned and sticked to bottom.
Currently, snackbar on tablet are left aligned and farther from bottom.
It doesn't look nice with the infobar which is center aligned.

Below is what the snackbar looks like on tablet after the change:
https://drive.google.com/open?id=0B1O0Z7eoZMuGT1NPcEhKb2VwdWM

BUG=723200

Review-Url: https://codereview.chromium.org/2892133002
Cr-Commit-Position: refs/heads/master@{#473583}
Committed:
https://chromium.googlesource.com/chromium/src/+/693c21e381f14e84e67137c2307e...
==========

[commit-bot: I haz the power, 2017-05-22 15:46:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/693c21e381f14e84e67137c2307e...