Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2892113002: [ios clean] Fixes Toolbar constraints. (Closed)

Created:
3 years, 7 months ago by sczs
Modified:
3 years, 7 months ago
Reviewers:
edchin
CC:
chromium-reviews, marq+scrutinize_chromium.org, lpromero+watch_chromium.org, ios-reviews+clean_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios clean] Fixes Toolbar constraints. Changes the constraints priority in ToolbarVC so these are not broken when the view is being hidden, or when the VC's view is being resized or is 0. After these changes there are no constraints warnings when displaying the Toolbar. BUG=683793 Review-Url: https://codereview.chromium.org/2892113002 Cr-Commit-Position: refs/heads/master@{#473074} Committed: https://chromium.googlesource.com/chromium/src/+/395846e25f371ada6ea16f59e7525b988c2c3fd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -25 lines) Patch
M ios/clean/chrome/browser/ui/toolbar/toolbar_button+factory.mm View 9 chunks +0 lines, -23 lines 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/toolbar_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/toolbar_constants.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm View 11 chunks +47 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
sczs
PTAL Ed, should be a quick review
3 years, 7 months ago (2017-05-19 00:00:59 UTC) #7
edchin
lgtm
3 years, 7 months ago (2017-05-19 00:12:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892113002/1
3 years, 7 months ago (2017-05-19 00:15:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-19 02:17:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892113002/1
3 years, 7 months ago (2017-05-19 03:47:06 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 04:00:27 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/395846e25f371ada6ea16f59e752...

Powered by Google App Engine
This is Rietveld 408576698