Initialize GpuDataManagerImpl after GpuDataManagerVisualProxy

Initialize GpuDataManagerImpl after GpuDataManagerVisualProxy

Transparent visuals became broken in software rendering mode after
[1], which caused GpuDataManagerVisualProxy to stop getting the
initial OnGpuInfoUpdate() from GpuDataManagerImpl.  This CL moves the
initialization of GDMI after GDMVP so this cannot happen.

[1] https://codereview.chromium.org/2805933002

R=piman@chromium.org
BUG=724297
Review-Url: https://codereview.chromium.org/2892093002
Cr-Commit-Position: refs/heads/master@{#473021}
Committed: https://chromium.googlesource.com/chromium/src/+/53f95703f2ce29b492ad6491b637a46d2c2c0ef2

[Tom Anderson, 2017-05-18 22:41:07]

Description was changed from

==========
Initialize GpuDataManagerImpl after GpuDataManagerVisualProxy

Transparent visuals became broken in software rendering mode after
[1], which caused GpuDataManagerVisualProxy to stop getting the
initial OnGpuInfoUpdate() from GpuDataManagerImpl.  This CL moves the
initialization of GDMI after GDMVP so this cannot happen.

[1] https://codereview.chromium.org/2805933002

R=piman@chromium.org
==========

to

==========
Initialize GpuDataManagerImpl after GpuDataManagerVisualProxy

Transparent visuals became broken in software rendering mode after
[1], which caused GpuDataManagerVisualProxy to stop getting the
initial OnGpuInfoUpdate() from GpuDataManagerImpl.  This CL moves the
initialization of GDMI after GDMVP so this cannot happen.

[1] https://codereview.chromium.org/2805933002

R=piman@chromium.org
BUG=724297
==========

[Tom Anderson, 2017-05-18 22:41:16]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 22:43:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-05-18 22:47:20]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[Tom Anderson, 2017-05-18 22:47:29]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-05-18 22:49:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2017-05-18 22:55:05]

lgtm

https://codereview.chromium.org/2892093002/diff/20001/content/browser/browser...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2892093002/diff/20001/content/browser/browser...
content/browser/browser_main_loop.cc:884: new
internal::GpuDataManagerVisualProxy(gpu_data_manager));
nit: maybe add a comment explaining that it's safe to use the gpu_data_manager
before Initialize, because all it does is add an observer (and conversely, we
want to observe before Initialize because that may be our only chance to get the
GPU info).

[Tom Anderson, 2017-05-18 23:36:51]

https://codereview.chromium.org/2892093002/diff/20001/content/browser/browser...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2892093002/diff/20001/content/browser/browser...
content/browser/browser_main_loop.cc:884: new
internal::GpuDataManagerVisualProxy(gpu_data_manager));
On 2017/05/18 22:55:05, piman wrote:
> nit: maybe add a comment explaining that it's safe to use the gpu_data_manager
> before Initialize, because all it does is add an observer (and conversely, we
> want to observe before Initialize because that may be our only chance to get
the
> GPU info).

Done.

[Tom Anderson, 2017-05-18 23:36:54]

The CQ bit was checked by thomasanderson@chromium.org

[Tom Anderson, 2017-05-18 23:36:54]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2892093002/#ps40001
(title: "Add comment")

[commit-bot: I haz the power, 2017-05-18 23:37:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 01:39:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495150614161120,
"parent_rev": "d3932e83e4d948d982d181fa79b166bc36f4f5d1", "commit_rev":
"53f95703f2ce29b492ad6491b637a46d2c2c0ef2"}

[commit-bot: I haz the power, 2017-05-19 01:39:22]

Description was changed from

==========
Initialize GpuDataManagerImpl after GpuDataManagerVisualProxy

Transparent visuals became broken in software rendering mode after
[1], which caused GpuDataManagerVisualProxy to stop getting the
initial OnGpuInfoUpdate() from GpuDataManagerImpl.  This CL moves the
initialization of GDMI after GDMVP so this cannot happen.

[1] https://codereview.chromium.org/2805933002

R=piman@chromium.org
BUG=724297
==========

to

==========
Initialize GpuDataManagerImpl after GpuDataManagerVisualProxy

Transparent visuals became broken in software rendering mode after
[1], which caused GpuDataManagerVisualProxy to stop getting the
initial OnGpuInfoUpdate() from GpuDataManagerImpl.  This CL moves the
initialization of GDMI after GDMVP so this cannot happen.

[1] https://codereview.chromium.org/2805933002

R=piman@chromium.org
BUG=724297

Review-Url: https://codereview.chromium.org/2892093002
Cr-Commit-Position: refs/heads/master@{#473021}
Committed:
https://chromium.googlesource.com/chromium/src/+/53f95703f2ce29b492ad6491b637...
==========

[commit-bot: I haz the power, 2017-05-19 01:39:24]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/53f95703f2ce29b492ad6491b637...