Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2892063002: Revert of Disable flaky ContinueWhereILeftOffTest.SessionStorage/SessionCookies tests (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
yoichio, sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky ContinueWhereILeftOffTest.SessionStorage/SessionCookies tests (patchset #1 id:1 of https://codereview.chromium.org/2750783002/ ) Reason for revert: Re-enabling the tests to see if the issue was fixed or get a call stack if it wasn't. See https://bugs.chromium.org/p/chromium/issues/detail?id=700696#c6 Original issue's description: > Disable flaky ContinueWhereILeftOffTest.SessionStorage/SessionCookies tests > > They are flaky. > > BUG=700696, 700699 > TBR=sky@chromium.org > > Review-Url: https://codereview.chromium.org/2750783002 > Cr-Commit-Position: refs/heads/master@{#456659} > Committed: https://chromium.googlesource.com/chromium/src/+/008c85e4011f9a860f94df75c3bd69c7aece6bab TBR=yoichio@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=700696, 700699 Review-Url: https://codereview.chromium.org/2892063002 Cr-Commit-Position: refs/heads/master@{#473168} Committed: https://chromium.googlesource.com/chromium/src/+/5fcdbcd466008a0669c1c1e9bcb77ae69010639e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/sessions/better_session_restore_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
fdoray
Created Revert of Disable flaky ContinueWhereILeftOffTest.SessionStorage/SessionCookies tests
3 years, 7 months ago (2017-05-18 19:11:05 UTC) #2
fdoray
Please take a look. Re-enabling the tests to see if the issue was fixed or ...
3 years, 7 months ago (2017-05-18 19:12:17 UTC) #7
yoichio
lgtm
3 years, 7 months ago (2017-05-19 01:49:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892063002/1
3 years, 7 months ago (2017-05-19 12:32:25 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 12:39:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5fcdbcd466008a0669c1c1e9bcb7...

Powered by Google App Engine
This is Rietveld 408576698