Revert of Schedule bitmap animation timers on the compositor task runner.

Revert of Schedule bitmap animation timers on the compositor task runner. (patchset #10 id:180001 of https://codereview.chromium.org/2810423003/ )

Reason for revert:
Makes CrSettingsRouteDynamicParametersTest.All fail most of the time (requiring retries). Exact reason isn't clear, but local bisect on Linux consistently points to this CL.

See also:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=CrSettingsRouteDynamicParametersTest.All

Original issue's description:
> Schedule bitmap animation timers on the compositor task runner.
> 
> GIF animation timers will now run on the compositor task runner (retrievable via TaskRunnerHelper::Get(kAnimationTimer)), which
> is now prioritised in UseCase::NONE over the main task runner. This
> allows animated GIFs to maintain their frame rate even in the presence
> of timer storms like:
> https://people-mozilla.org/~bkelly/timer-flood/index.html
> 
> BUG=703608
> 
> Review-Url: https://codereview.chromium.org/2810423003
> Cr-Commit-Position: refs/heads/master@{#472427}
> Committed: https://chromium.googlesource.com/chromium/src/+/f5065232010251bad1cccddcc2a0d27ac2232f67

TBR=chrishtr@chromium.org,skyostil@chromium.org,delphick@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=703608, 724124

[jbroman, 2017-05-18 19:07:38]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2017-05-18 19:07:39]

Created Revert of Schedule bitmap animation timers on the compositor task
runner.

[jbroman, 2017-05-18 19:07:49]

Description was changed from

==========
Revert of Schedule bitmap animation timers on the compositor task runner.
(patchset #10 id:180001 of https://codereview.chromium.org/2810423003/ )

Reason for revert:
Makes CrSettingsRouteDynamicParametersTest.All fail most of the time (requiring
retries). Exact reason isn't clear, but local bisect on Linux consistently
points to this CL.

See also:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType...

Original issue's description:
> Schedule bitmap animation timers on the compositor task runner.
> 
> GIF animation timers will now run on the compositor task runner (retrievable
via TaskRunnerHelper::Get(kAnimationTimer)), which
> is now prioritised in UseCase::NONE over the main task runner. This
> allows animated GIFs to maintain their frame rate even in the presence
> of timer storms like:
> https://people-mozilla.org/~bkelly/timer-flood/index.html
> 
> BUG=703608
> 
> Review-Url: https://codereview.chromium.org/2810423003
> Cr-Commit-Position: refs/heads/master@{#472427}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f5065232010251bad1cccddcc2a0...

TBR=chrishtr@chromium.org,skyostil@chromium.org,delphick@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=703608
==========

to

==========
Revert of Schedule bitmap animation timers on the compositor task runner.
(patchset #10 id:180001 of https://codereview.chromium.org/2810423003/ )

Reason for revert:
Makes CrSettingsRouteDynamicParametersTest.All fail most of the time (requiring
retries). Exact reason isn't clear, but local bisect on Linux consistently
points to this CL.

See also:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType...

Original issue's description:
> Schedule bitmap animation timers on the compositor task runner.
> 
> GIF animation timers will now run on the compositor task runner (retrievable
via TaskRunnerHelper::Get(kAnimationTimer)), which
> is now prioritised in UseCase::NONE over the main task runner. This
> allows animated GIFs to maintain their frame rate even in the presence
> of timer storms like:
> https://people-mozilla.org/~bkelly/timer-flood/index.html
> 
> BUG=703608
> 
> Review-Url: https://codereview.chromium.org/2810423003
> Cr-Commit-Position: refs/heads/master@{#472427}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f5065232010251bad1cccddcc2a0...

TBR=chrishtr@chromium.org,skyostil@chromium.org,delphick@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=703608,724124
==========

[commit-bot: I haz the power, 2017-05-18 19:08:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 19:13:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 19:13:52]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jbroman, 2017-05-18 19:19:00]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-05-18 19:20:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Elphick, 2017-05-18 19:46:28]

On 2017/05/18 19:07:39, jbroman wrote:
> Created Revert of Schedule bitmap animation timers on the compositor task
> runner.

I've created a partial revert already:
https://chromium-review.googlesource.com/c/508792/

Seems to be stalled due to problems on the windows bots, but hopefully the retry
succeeds.

I'm fairly sure this the compositor priority part of my original change is the
reason for this flakiness, so I'd rather we avoided a full revert.

[jbroman, 2017-05-18 19:49:01]

The CQ bit was unchecked by jbroman@chromium.org

[jbroman, 2017-05-18 19:49:43]

On 2017/05/18 at 19:46:28, delphick wrote:
> On 2017/05/18 19:07:39, jbroman wrote:
> > Created Revert of Schedule bitmap animation timers on the compositor task
> > runner.
> 
> I've created a partial revert already:
https://chromium-review.googlesource.com/c/508792/
> 
> Seems to be stalled due to problems on the windows bots, but hopefully the
retry succeeds.
> 
> I'm fairly sure this the compositor priority part of my original change is the
reason for this flakiness, so I'd rather we avoided a full revert.

Given your CL is already in the CQ, okay. Generally I'd rather revert to a known
good state and then reland changes afterwards.

[Dan Elphick, 2017-05-18 20:00:15]

On 2017/05/18 19:49:43, jbroman wrote:
> On 2017/05/18 at 19:46:28, delphick wrote:
> > On 2017/05/18 19:07:39, jbroman wrote:
> > > Created Revert of Schedule bitmap animation timers on the compositor task
> > > runner.
> > 
> > I've created a partial revert already:
> https://chromium-review.googlesource.com/c/508792/
> > 
> > Seems to be stalled due to problems on the windows bots, but hopefully the
> retry succeeds.
> > 
> > I'm fairly sure this the compositor priority part of my original change is
the
> reason for this flakiness, so I'd rather we avoided a full revert.
> 
> Given your CL is already in the CQ, okay. Generally I'd rather revert to a
known
> good state and then reland changes afterwards.

That's fair - Sorry about the issues this caused.

I guess we can allow the CLs to race to see which one lands first. Given the
general flakiness of windows builds this might make a resolution faster.

[jbroman, 2017-05-18 23:51:58]

On 2017/05/18 at 20:00:15, delphick wrote:
> On 2017/05/18 19:49:43, jbroman wrote:
> > On 2017/05/18 at 19:46:28, delphick wrote:
> > > On 2017/05/18 19:07:39, jbroman wrote:
> > > > Created Revert of Schedule bitmap animation timers on the compositor
task
> > > > runner.
> > > 
> > > I've created a partial revert already:
> > https://chromium-review.googlesource.com/c/508792/
> > > 
> > > Seems to be stalled due to problems on the windows bots, but hopefully the
> > retry succeeds.
> > > 
> > > I'm fairly sure this the compositor priority part of my original change is
the
> > reason for this flakiness, so I'd rather we avoided a full revert.
> > 
> > Given your CL is already in the CQ, okay. Generally I'd rather revert to a
known
> > good state and then reland changes afterwards.
> 
> That's fair - Sorry about the issues this caused.
> 
> I guess we can allow the CLs to race to see which one lands first. Given the
general flakiness of windows builds this might make a resolution faster.

Closing; partial revert landed.