Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1794)

Issue 2892033003: Change checkbox size for ImportantSites dialog (Closed)

Created:
3 years, 7 months ago by dullweber
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, tfarina, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change checkbox size for ImportantSites dialog Make checkboxes in ImportantSites consistent with Clear Browsing Data. https://screenshot.googleplex.com/WBX7VZCsg6s.png BUG=698692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2892033003 Cr-Commit-Position: refs/heads/master@{#473528} Committed: https://chromium.googlesource.com/chromium/src/+/86c6630be664b9e45726d93c8fa0017967d56ddf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/important_site_checkbox.html View 1 chunk +10 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
dullweber
I noticed that the size of the checkboxes was reduced for CBD, so I'm using ...
3 years, 7 months ago (2017-05-19 07:56:44 UTC) #4
Dan Beam
lgtm
3 years, 7 months ago (2017-05-21 18:25:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892033003/1
3 years, 7 months ago (2017-05-22 07:44:39 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 08:55:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/86c6630be664b9e45726d93c8fa0...

Powered by Google App Engine
This is Rietveld 408576698