Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2892033002: Enable support for draft-ietf-webpush-encryption-08 (Closed)

Created:
3 years, 7 months ago by Peter Beverloo
Modified:
3 years, 7 months ago
Reviewers:
johnme, eroman, Ilya Sherman
CC:
chromium-reviews, awdf+watch_chromium.org, zea+watch_chromium.org, Peter Beverloo, johnme+watch_chromium.org, haraken, asvitkine+watch_chromium.org, blink-reviews, jshin+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable support for draft-ietf-webpush-encryption-08 This CL hooks up the ability to decrypt incoming Push messages according to the draft-ietf-webpush-encryption-08 encryption scheme. It also adds the "aes128gcm" content coding to PushManager.supportedContentEncodings. Standard: https://tools.ietf.org/html/draft-ietf-webpush-encryption-08 https://tools.ietf.org/html/draft-ietf-httpbis-encryption-encoding-08 Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/SX9_nZ1NHy8/discussion BUG=679789 Review-Url: https://codereview.chromium.org/2892033002 Cr-Commit-Position: refs/heads/master@{#474246} Committed: https://chromium.googlesource.com/chromium/src/+/9148da4ab010a58d8ac6c0f2247cd9a06512d9ca

Patch Set 1 #

Patch Set 2 : Enable support for draft-ietf-webpush-encryption-08 #

Total comments: 7

Patch Set 3 : Enable support for draft-ietf-webpush-encryption-08 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -106 lines) Patch
M components/gcm_driver/crypto/gcm_encryption_provider.h View 1 2 4 chunks +21 lines, -7 lines 0 comments Download
M components/gcm_driver/crypto/gcm_encryption_provider.cc View 1 2 10 chunks +127 lines, -71 lines 0 comments Download
M components/gcm_driver/crypto/gcm_encryption_provider_unittest.cc View 1 2 6 chunks +75 lines, -20 lines 0 comments Download
M components/gcm_driver/gcm_driver.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/gcm_driver/gcm_stats_recorder_android.cc View 1 chunk +4 lines, -1 line 0 comments Download
M components/gcm_driver/gcm_stats_recorder_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/push_messaging/pushmanager-supported-content-encodings.html View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
Peter Beverloo
+johnme, PTAL Not completely finished yet, but the core bits are there.
3 years, 7 months ago (2017-05-22 16:58:53 UTC) #2
johnme
lgtm https://codereview.chromium.org/2892033002/diff/20001/components/gcm_driver/crypto/gcm_encryption_provider.cc File components/gcm_driver/crypto/gcm_encryption_provider.cc (right): https://codereview.chromium.org/2892033002/diff/20001/components/gcm_driver/crypto/gcm_encryption_provider.cc#newcode238 components/gcm_driver/crypto/gcm_encryption_provider.cc:238: message.sender_id, salt, public_key, record_size, ciphertext, Use std::move(ciphertext) to ...
3 years, 7 months ago (2017-05-23 17:37:49 UTC) #3
Peter Beverloo
+isherman for UMA https://codereview.chromium.org/2892033002/diff/20001/components/gcm_driver/crypto/gcm_encryption_provider.cc File components/gcm_driver/crypto/gcm_encryption_provider.cc (right): https://codereview.chromium.org/2892033002/diff/20001/components/gcm_driver/crypto/gcm_encryption_provider.cc#newcode238 components/gcm_driver/crypto/gcm_encryption_provider.cc:238: message.sender_id, salt, public_key, record_size, ciphertext, On ...
3 years, 7 months ago (2017-05-23 17:58:33 UTC) #7
Ilya Sherman
On 2017/05/23 17:58:33, Peter Beverloo wrote: > +isherman for UMA enums.xml lgtm (I'm assuming that's ...
3 years, 7 months ago (2017-05-23 21:32:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892033002/40001
3 years, 7 months ago (2017-05-24 09:15:45 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 10:55:59 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9148da4ab010a58d8ac6c0f2247c...

Powered by Google App Engine
This is Rietveld 408576698