Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2891993002: WebUI: Stop keypresses on the close icon from firing the Enter handler. (Closed)

Created:
3 years, 7 months ago by tommycli
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

WebUI: Stop keypresses on the close icon from firing the Enter handler. Previously, Enter keypresses on the close icon could trigger the whole dialog's default Enter handler. This CL prevents that. BUG=719387 TEST=MANUAL R=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2884113002 Cr-Original-Commit-Position: refs/heads/master@{#472159} Review-Url: https://codereview.chromium.org/2891993002 . Cr-Commit-Position: refs/branch-heads/3071@{#617} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/acd447c3e9f8477a25a76054f7b940728da30107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chrome/test/data/webui/cr_elements/cr_dialog_test.js View 2 chunks +7 lines, -3 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tommycli
3 years, 7 months ago (2017-05-18 17:40:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
acd447c3e9f8477a25a76054f7b940728da30107.

Powered by Google App Engine
This is Rietveld 408576698