Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2891963002: reland: Remove WINDOW_TYPE_V1_PANEL AppWindow type (Closed)

Created:
3 years, 7 months ago by Qiang(Joe) Xu
Modified:
3 years, 7 months ago
Reviewers:
benwells, oshima
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, sadrul, kalyank, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

reland: Remove WINDOW_TYPE_V1_PANEL AppWindow type Changes: Currently, panel window is only used as Chrome OS's audio player, which is WINDOW_TYPE_PANEL. WINDOW_TYPE_V1_PANEL is not a AppWindow type in use any more. Remove it in code base. TBR=oshima@chromium.org, benwells@chromium.org BUG=691099 TEST=covered by tests Review-Url: https://codereview.chromium.org/2886293002 Cr-Commit-Position: refs/heads/master@{#472661} Committed: https://chromium.googlesource.com/chromium/src/+/0775f98187d5d895b15b46212f55d30956aa946e patch from issue 2886293002 at patchset 20001 (http://crrev.com/2886293002#ps20001) Review-Url: https://codereview.chromium.org/2891963002 Cr-Commit-Position: refs/heads/master@{#472853} Committed: https://chromium.googlesource.com/chromium/src/+/64e280e83e00b3d5217595c55312a3251f682fdf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -69 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_api.cc View 5 chunks +2 lines, -53 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/app_window/app_window.h View 2 chunks +1 line, -4 lines 0 comments Download
M extensions/components/native_app_window/native_app_window_views.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/components/native_app_window/native_app_window_views.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891963002/1
3 years, 7 months ago (2017-05-18 16:11:00 UTC) #2
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 17:15:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/64e280e83e00b3d5217595c55312...

Powered by Google App Engine
This is Rietveld 408576698