content/browser/devtools/protocol/system_info_handler.cc - Issue 2891933004: Remove raw base::DictionaryValue::Set in //content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/system_info_handler.cc

Issue 2891933004: Remove raw base::DictionaryValue::Set in //content (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/system_info_handler.cc

diff --git a/content/browser/devtools/protocol/system_info_handler.cc b/content/browser/devtools/protocol/system_info_handler.cc

index a5e1b7303f1710f6993af3a4059482b1dc858e67..ac0c8be5900499a74c81ece41b816be548ebbaab 100644

--- a/content/browser/devtools/protocol/system_info_handler.cc

+++ b/content/browser/devtools/protocol/system_info_handler.cc

@@ -110,7 +110,7 @@ void SendGetInfoResponse(std::unique_ptr<GetInfoCallback> callback) {

gpu_info.EnumerateFields(&enumerator);

std::unique_ptr<base::DictionaryValue> base_feature_status =

- base::WrapUnique(GetFeatureStatus());

+ GetFeatureStatus();

std::unique_ptr<protocol::DictionaryValue> feature_status =

protocol::DictionaryValue::cast(

protocol::toProtocolValue(base_feature_status.get(), 1000));