Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2891923006: Add the status of ARC to the Feedback PSDs. (Closed)

Created:
3 years, 7 months ago by afakhry
Modified:
3 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the status of ARC to the Feedback PSDs. Add an entry that shows whether the user opted in ARC so that it's immediately available in the feedback report's Product Specific Data (PSD). BUG=723951 TEST=System info should show an entry "CHROMEOS_ARC_STATUS" with value either "enabled" or "disbaled" Review-Url: https://codereview.chromium.org/2891923006 Cr-Commit-Position: refs/heads/master@{#473279} Committed: https://chromium.googlesource.com/chromium/src/+/e9ba1aac43fd0a5f81fbafde6cd71416ceba38f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc View 11 chunks +28 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
afakhry
Xiyuan, can you please review? Thank you.
3 years, 7 months ago (2017-05-19 18:19:14 UTC) #4
xiyuan
lgtm
3 years, 7 months ago (2017-05-19 18:30:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891923006/1
3 years, 7 months ago (2017-05-19 19:12:20 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 19:37:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e9ba1aac43fd0a5f81fbafde6cd7...

Powered by Google App Engine
This is Rietveld 408576698