Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2891923005: Revert of Save pdf file instead of web page through context menu for embedded pdf file (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
Wei Li, lazyboy
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Save pdf file instead of web page through context menu for embedded pdf file (patchset #8 id:160001 of https://codereview.chromium.org/2862583010/ ) Reason for revert: PdfPluginContextMenuBrowserTest.EmbeddedPdfHasNoPageItems is flaky on Windows, see: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=PdfPluginContextMenuBrowserTest.EmbeddedPdfHasNoPageItems Original issue's description: > Save pdf file instead of web page through context menu for embedded pdf file > > When user clicks 'Save as...' in the context menu over an embedded pdf file, > we should save the pdf file instead of the entire web page. We fix this by showing > the correct context menu for embedded pdf versus full page pdf: only full page > pdf's context menu shows page navigation items such as 'Reload', > but embedded pdf's context menu doesn't show them. > > BUG=chromium:591071 > > Review-Url: https://codereview.chromium.org/2862583010 > Cr-Commit-Position: refs/heads/master@{#473105} > Committed: https://chromium.googlesource.com/chromium/src/+/fd0e534843ac5926c1b26c7e1e7a7229fcb3aeee TBR=lazyboy@chromium.org,weili@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:591071 Review-Url: https://codereview.chromium.org/2891923005 Cr-Commit-Position: refs/heads/master@{#473171} Committed: https://chromium.googlesource.com/chromium/src/+/ab6a896a5431f19e96cbc15ce7920730ac4ace51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -159 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc View 6 chunks +0 lines, -122 lines 0 comments Download
D chrome/test/data/pdf/test-embed-pdf.html View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/pdf/test-iframe-pdf.html View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Marc Treib
Created Revert of Save pdf file instead of web page through context menu for embedded ...
3 years, 7 months ago (2017-05-19 12:58:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891923005/1
3 years, 7 months ago (2017-05-19 12:58:30 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 12:59:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab6a896a5431f19e96cbc15ce792...

Powered by Google App Engine
This is Rietveld 408576698