Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2891923003: chromeos: Tighten DEPS on //ash in //chrome/browser to support mash (Closed)

Created:
3 years, 7 months ago by James Cook
Modified:
3 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, extensions-reviews_chromium.org, awdf+watch_chromium.org, Peter Beverloo, chfremer+watch_chromium.org, mlamouri+watch-notifications_chromium.org, feature-media-reviews_chromium.org, sync-reviews_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Tighten DEPS on //ash in //chrome/browser to support mash Under mash the code in //ash runs out of process. Code in //chrome/browser must use the mojo interfaces in //ash/public/interfaces to talk to ash. We're still in the process of refactoring existing code, but new code should use the mojo approach. Tighten DEPS on //ash to limit the number of new references. Also file bugs to refactor the existing areas. BUG=678705 TEST=buildtools/checkdeps/checkdeps.py Review-Url: https://codereview.chromium.org/2891923003 Cr-Commit-Position: refs/heads/master@{#475577} Committed: https://chromium.googlesource.com/chromium/src/+/1f91eac1eb56feff498ccee8e88ab96a0a66b024

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -9 lines) Patch
M chrome/browser/DEPS View 1 4 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/cryptauth/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/lifetime/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc/DEPS View 1 chunk +8 lines, -3 lines 0 comments Download
A chrome/browser/memory/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/notifications/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/DEPS View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/browser/renderer_context_menu/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/browser/signin/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/sync/DEPS View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/usb/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
James Cook
sky, please take a look. I'm planning to wait until next week to land this. ...
3 years, 7 months ago (2017-05-18 17:39:33 UTC) #4
sky
LGTM
3 years, 7 months ago (2017-05-18 19:39:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891923003/20001
3 years, 6 months ago (2017-05-30 17:09:56 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 17:27:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f91eac1eb56feff498ccee8e88a...

Powered by Google App Engine
This is Rietveld 408576698