Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2891913005: Implement a few BrowserAccessibilityComWin methods with AXPlatformNodeWin. (Closed)

Created:
3 years, 7 months ago by dougt
Modified:
3 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement a few BrowserAccessibilityComWin methods with AXPlatformNodeWin. In this CL, we will implement the following in terms of AXPlatformNodeWin: get_accChild get_accChildCount get_accDefaultAction get_accDescription get_accFocus get_accParent accDoDefaultAction BUG=703369 Review-Url: https://codereview.chromium.org/2891913005 Cr-Commit-Position: refs/heads/master@{#473803} Committed: https://chromium.googlesource.com/chromium/src/+/6458fe10187e3a93348f6f15551ad82551f7c44c

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -104 lines) Patch
M content/browser/accessibility/browser_accessibility.cc View 1 chunk +15 lines, -5 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.cc View 1 7 chunks +8 lines, -99 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (15 generated)
dougt
Hi Mr Mazzoni, please take a look.
3 years, 7 months ago (2017-05-19 22:46:04 UTC) #11
dmazzoni
lgtm
3 years, 7 months ago (2017-05-22 21:12:13 UTC) #12
commit-bot: I haz the power
This CL has an open dependency (Issue 2894673003 Patch 1). Please resolve the dependency and ...
3 years, 7 months ago (2017-05-22 22:06:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891913005/20001
3 years, 7 months ago (2017-05-23 02:35:49 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 03:53:08 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6458fe10187e3a93348f6f15551a...

Powered by Google App Engine
This is Rietveld 408576698