Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 2891913003: Simplify Linux host startup script. (Closed)

Created:
3 years, 7 months ago by Gus Smith
Modified:
3 years, 7 months ago
Reviewers:
Lambros, nicholss
CC:
chromium-reviews, chromoting-reviews_chromium.org, nicholss
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify Linux host startup script. Replaces the g_desktops list with g_desktop, a single object. The script was originally written to handle a number of sessions at once, which were stored in g_desktops; however, we determined this feature wasn't needed and thus removed it to make the code simpler. Review-Url: https://codereview.chromium.org/2891913003 Cr-Commit-Position: refs/heads/master@{#473692} Committed: https://chromium.googlesource.com/chromium/src/+/faa560faa97d24e9266c6a4a3e0169e735a4c2d7

Patch Set 1 : Simplify Linux host startup script. #

Total comments: 1

Patch Set 2 : Simplify Linux host startup script. #

Patch Set 3 : Simplify Linux host startup script. #

Patch Set 4 : Simplify Linux host startup script. #

Patch Set 5 : Simplify Linux host startup script. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M remoting/host/linux/linux_me2me_host.py View 1 2 3 4 6 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
Gus Smith
3 years, 7 months ago (2017-05-18 20:36:31 UTC) #2
Lambros
lgtm https://codereview.chromium.org/2891913003/diff/1/remoting/host/linux/linux_me2me_host.py File remoting/host/linux/linux_me2me_host.py (right): https://codereview.chromium.org/2891913003/diff/1/remoting/host/linux/linux_me2me_host.py#newcode411 remoting/host/linux/linux_me2me_host.py:411: g_desktop = self optional: Maybe assert() or raise ...
3 years, 7 months ago (2017-05-18 20:39:59 UTC) #4
Gus Smith
According to Lambros's suggestion, added an assert to check that the g_desktop variable hasn't been ...
3 years, 7 months ago (2017-05-22 18:45:36 UTC) #7
nicholss
lgtm, just remove the BUG= from the description.
3 years, 7 months ago (2017-05-22 20:19:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891913003/80001
3 years, 7 months ago (2017-05-22 20:59:10 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 21:09:51 UTC) #23
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/faa560faa97d24e9266c6a4a3e01...

Powered by Google App Engine
This is Rietveld 408576698