|
|
DescriptionSimplify Linux host startup script.
Replaces the g_desktops list with g_desktop, a single object. The script was originally written to handle a number of sessions at once, which were stored in g_desktops; however, we determined this feature wasn't needed and thus removed it to make the code simpler.
Review-Url: https://codereview.chromium.org/2891913003
Cr-Commit-Position: refs/heads/master@{#473692}
Committed: https://chromium.googlesource.com/chromium/src/+/faa560faa97d24e9266c6a4a3e0169e735a4c2d7
Patch Set 1 : Simplify Linux host startup script. #
Total comments: 1
Patch Set 2 : Simplify Linux host startup script. #Patch Set 3 : Simplify Linux host startup script. #Patch Set 4 : Simplify Linux host startup script. #Patch Set 5 : Simplify Linux host startup script. #Messages
Total messages: 23 (17 generated)
gusss@google.com changed reviewers: + lambroslambrou@chromium.org
The CQ bit was checked by gusss@google.com to run a CQ dry run
lgtm https://codereview.chromium.org/2891913003/diff/1/remoting/host/linux/linux_m... File remoting/host/linux/linux_me2me_host.py (right): https://codereview.chromium.org/2891913003/diff/1/remoting/host/linux/linux_m... remoting/host/linux/linux_me2me_host.py:411: g_desktop = self optional: Maybe assert() or raise an error if g_desktop is not null ?
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Replaces g_desktops, which was a list, with g_desktop, a single instance. BUG= ========== to ========== Simplify Linux host startup script. Replaces the g_desktops list with g_desktop, a single object. The script was originally written to handle a number of sessions at once, which were stored in g_desktops; however, we determined this feature wasn't needed and thus removed it to make the code simpler. BUG= ==========
According to Lambros's suggestion, added an assert to check that the g_desktop variable hasn't been set already. Also fixed a related bug where I'd forgotten the `global` keyword.
nicholss@chromium.org changed reviewers: + nicholss@chromium.org
lgtm, just remove the BUG= from the description.
Description was changed from ========== Simplify Linux host startup script. Replaces the g_desktops list with g_desktop, a single object. The script was originally written to handle a number of sessions at once, which were stored in g_desktops; however, we determined this feature wasn't needed and thus removed it to make the code simpler. BUG= ========== to ========== Simplify Linux host startup script. Replaces the g_desktops list with g_desktop, a single object. The script was originally written to handle a number of sessions at once, which were stored in g_desktops; however, we determined this feature wasn't needed and thus removed it to make the code simpler. ==========
The CQ bit was checked by nicholss@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lambroslambrou@chromium.org Link to the patchset: https://codereview.chromium.org/2891913003/#ps80001 (title: "Simplify Linux host startup script.")
The CQ bit was checked by gusss@google.com
The CQ bit was unchecked by gusss@google.com
The CQ bit was checked by gusss@google.com
The CQ bit was unchecked by gusss@google.com
The CQ bit was checked by gusss@google.com
The CQ bit was unchecked by gusss@google.com
The CQ bit was checked by nicholss@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495486721963760, "parent_rev": "1e455f10f5d7b820b2b9151ac71ba1309cdeeb35", "commit_rev": "faa560faa97d24e9266c6a4a3e0169e735a4c2d7"}
Message was sent while issue was closed.
Description was changed from ========== Simplify Linux host startup script. Replaces the g_desktops list with g_desktop, a single object. The script was originally written to handle a number of sessions at once, which were stored in g_desktops; however, we determined this feature wasn't needed and thus removed it to make the code simpler. ========== to ========== Simplify Linux host startup script. Replaces the g_desktops list with g_desktop, a single object. The script was originally written to handle a number of sessions at once, which were stored in g_desktops; however, we determined this feature wasn't needed and thus removed it to make the code simpler. Review-Url: https://codereview.chromium.org/2891913003 Cr-Commit-Position: refs/heads/master@{#473692} Committed: https://chromium.googlesource.com/chromium/src/+/faa560faa97d24e9266c6a4a3e01... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/faa560faa97d24e9266c6a4a3e01... |