DescriptionRevert of Updates Zoom bubble layout and adds +/- buttons (patchset #17 id:560001 of https://codereview.chromium.org/2845593002/ )
Reason for revert:
Broke "ChromiumOS x86-generic Compile" bot.
The bot uses gcc instead of clang, and needs more std::move()s.
Original issue's description:
> Updates Zoom bubble layout and adds +/- buttons
>
> Adds + and - buttons to the Zoom bubble.
> Updates layout to only have one row.
>
> With this change the zoom icon (ZoomView) in location bar
> can be shown even at 100% zoom as long as the zoom bubble
> is also shown (otherwise the bubble loses its anchor when
> using + / - buttons to go over 100% zoom without closing
> the bubble.
> In this scenario a kZoomPlusIcon is used (rather than none).
> Whenever the zoom bubble gets closed the location bar gets
> updated to update layout and visibility of the zoom icon.
>
> BUG=651641
> TEST=no new tests but a few existing tests updated or checked
> ZoomControllerTest
> ZoomDecorationTest
> ZoomControllerBrowserTest
> PDFExtensionTest.PdfZoomWithoutBubble
> TBR=phajdan.jr@chromium.org (for a trivial change in chrome/test/base/test_browser_window.h)
>
> Review-Url: https://codereview.chromium.org/2845593002
> Cr-Commit-Position: refs/heads/master@{#472611}
> Committed: https://chromium.googlesource.com/chromium/src/+/c4d839e6e1f0963b2760620cb0ed072b802bf225
TBR=estade@chromium.org,pkasting@chromium.org,tapted@chromium.org,wjmaclean@chromium.org,varkha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651641
Review-Url: https://codereview.chromium.org/2891883002
Cr-Commit-Position: refs/heads/master@{#472625}
Committed: https://chromium.googlesource.com/chromium/src/+/ee42f00f402c8d2aff960d60079e77a94fc5aed5
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|