Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2891883002: Revert of Updates Zoom bubble layout and adds +/- buttons (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Updates Zoom bubble layout and adds +/- buttons (patchset #17 id:560001 of https://codereview.chromium.org/2845593002/ ) Reason for revert: Broke "ChromiumOS x86-generic Compile" bot. The bot uses gcc instead of clang, and needs more std::move()s. Original issue's description: > Updates Zoom bubble layout and adds +/- buttons > > Adds + and - buttons to the Zoom bubble. > Updates layout to only have one row. > > With this change the zoom icon (ZoomView) in location bar > can be shown even at 100% zoom as long as the zoom bubble > is also shown (otherwise the bubble loses its anchor when > using + / - buttons to go over 100% zoom without closing > the bubble. > In this scenario a kZoomPlusIcon is used (rather than none). > Whenever the zoom bubble gets closed the location bar gets > updated to update layout and visibility of the zoom icon. > > BUG=651641 > TEST=no new tests but a few existing tests updated or checked > ZoomControllerTest > ZoomDecorationTest > ZoomControllerBrowserTest > PDFExtensionTest.PdfZoomWithoutBubble > TBR=phajdan.jr@chromium.org (for a trivial change in chrome/test/base/test_browser_window.h) > > Review-Url: https://codereview.chromium.org/2845593002 > Cr-Commit-Position: refs/heads/master@{#472611} > Committed: https://chromium.googlesource.com/chromium/src/+/c4d839e6e1f0963b2760620cb0ed072b802bf225 TBR=estade@chromium.org,pkasting@chromium.org,tapted@chromium.org,wjmaclean@chromium.org,varkha@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=651641 Review-Url: https://codereview.chromium.org/2891883002 Cr-Commit-Position: refs/heads/master@{#472625} Committed: https://chromium.googlesource.com/chromium/src/+/ee42f00f402c8d2aff960d60079e77a94fc5aed5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -262 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +15 lines, -6 lines 0 comments Download
M chrome/app/vector_icons/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/app/vector_icons/add.icon View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/app/vector_icons/add.1x.icon View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/app/vector_icons/remove.icon View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/app/vector_icons/remove.1x.icon View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm View 2 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/location_bar/location_bar.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.h View 3 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 11 chunks +53 lines, -154 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_controller_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/zoom/zoom_controller.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Lei Zhang
Created Revert of Updates Zoom bubble layout and adds +/- buttons
3 years, 7 months ago (2017-05-18 02:02:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891883002/1
3 years, 7 months ago (2017-05-18 02:05:40 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 02:06:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ee42f00f402c8d2aff960d60079e...

Powered by Google App Engine
This is Rietveld 408576698