ntp4: Fix some closure compiler annotations in apps_page.js

chrome/browser/resources/ntp4/apps_page.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('ntp', function() {
   'use strict';
 
   var APP_LAUNCH = {
     // The histogram buckets (keep in sync with extension_constants.h).
     NTP_APPS_MAXIMIZED: 0,
@@ skipping 27 matching lines @@
   cr.addSingletonGetter(AppContextMenu);
 
   AppContextMenu.prototype = {
     initialize: function() {
       var menu = new cr.ui.Menu;
       cr.ui.decorate(menu, cr.ui.Menu);
       menu.classList.add('app-context-menu');
       this.menu = menu;
 
       this.launch_ = this.appendMenuItem_();
-      this.launch_.addEventListener('activate', this.onLaunch_.bind(this));
+      this.launch_.addEventListener('activate', this.onActivate_.bind(this));
 
       menu.appendChild(cr.ui.MenuItem.createSeparator());
       this.launchRegularTab_ = this.appendMenuItem_('applaunchtyperegular');
       this.launchPinnedTab_ = this.appendMenuItem_('applaunchtypepinned');
       if (loadTimeData.getBoolean('canHostedAppsOpenInWindows'))
         this.launchNewWindow_ = this.appendMenuItem_('applaunchtypewindow');
       this.launchFullscreen_ = this.appendMenuItem_('applaunchtypefullscreen');
 
       var self = this;
       this.forAllLaunchTypes_(function(launchTypeButton, id) {
@@ skipping 29 matching lines @@
             'activate', this.onCreateShortcut_.bind(this));
       }
 
       document.body.appendChild(menu);
     },
 
     /**
      * Appends a menu item to |this.menu|.
      * @param {string=} opt_textId If defined, the ID for the localized string
      *     that acts as the item's label.
+     * @private
      */
     appendMenuItem_: function(opt_textId) {
       var button = cr.doc.createElement('button');
       this.menu.appendChild(button);
       cr.ui.decorate(button, cr.ui.MenuItem);
       if (opt_textId)
         button.textContent = loadTimeData.getString(opt_textId);
       return button;
     },
 
     /**
      * Iterates over all the launch type menu items.
      * @param {function(cr.ui.MenuItem, number)} f The function to call for each
      *     menu item. The parameters to the function include the menu item and
      *     the associated launch ID.
+     * @private
      */
     forAllLaunchTypes_: function(f) {
       // Order matters: index matches launchType id.
       var launchTypes = [this.launchPinnedTab_,
                          this.launchRegularTab_,
                          this.launchFullscreen_,
                          this.launchNewWindow_];
 
       for (var i = 0; i < launchTypes.length; ++i) {
         if (!launchTypes[i])
@@ skipping 40 matching lines @@
 
       if (cr.isMac) {
         // On Windows and Linux, these should always be visible. On ChromeOS,
         // they are never created. On Mac, shortcuts can only be created for
         // new-style packaged apps, so hide the menu item.
         this.createShortcutSeparator_.hidden = this.createShortcut_.hidden =
             !app.appData.packagedApp;
       }
     },
 
+    /** @private */
+    onActivate_: function() {
+      chrome.send('launchApp', [this.app_.appId, APP_LAUNCH.NTP_APPS_MENU]);
+    },
+
     /**
-     * Handlers for menu item activation.
-     * @param {Event} e The activation event.
+     * @param {Event} e
      * @private
      */
-    onLaunch_: function(e) {
-      chrome.send('launchApp', [this.app_.appId, APP_LAUNCH.NTP_APPS_MENU]);
-    },
     onLaunchTypeChanged_: function(e) {
       var pressed = e.currentTarget;
       var app = this.app_;
       var targetLaunchType = pressed;
       // When bookmark apps are enabled, hosted apps can only toggle between
       // open as window and open as tab.
       if (loadTimeData.getBoolean('enableNewBookmarkApps')) {
         targetLaunchType = this.launchNewWindow_.checked ?
             this.launchRegularTab_ : this.launchNewWindow_;
       }
       this.forAllLaunchTypes_(function(launchTypeButton, id) {
         if (launchTypeButton == targetLaunchType) {
           chrome.send('setLaunchType', [app.appId, id]);
           // Manually update the launch type. We will only get
           // appsPrefChangeCallback calls after changes to other NTP instances.
           app.appData.launch_type = id;
         }
       });
     },
-    onShowOptions_: function(e) {
+
+    /** @private */
+    onShowOptions_: function() {
       window.location = this.app_.appData.optionsUrl;
     },
-    onShowDetails_: function(e) {
+
+    /** @private */
+    onShowDetails_: function() {
       var url = this.app_.appData.detailsUrl;
       url = appendParam(url, 'utm_source', 'chrome-ntp-launcher');
       window.location = url;
     },
-    onUninstall_: function(e) {
+
+    /** @private */
+    onUninstall_: function() {
       chrome.send('uninstallApp', [this.app_.appData.id]);
     },
-    onCreateShortcut_: function(e) {
+
+    /** @private */
+    onCreateShortcut_: function() {
       chrome.send('createAppShortcut', [this.app_.appData.id]);
     },
-    onShowAppInfo_: function(e) {
+
+    /** @private */
+    onShowAppInfo_: function() {
       chrome.send('showAppInfo', [this.app_.appData.id]);
     }
   };
 
   /**
    * Creates a new App object.
    * @param {Object} appData The data object that describes the app.
    * @constructor
    * @extends {HTMLDivElement}
    */
@@ skipping 116 matching lines @@
     setBounds: function(size, x, y) {
       var imgSize = size * APP_IMG_SIZE_FRACTION;
       this.appImgContainer_.style.width = this.appImgContainer_.style.height =
           toCssPx(imgSize);
       this.style.width = this.style.height = toCssPx(size);
       this.style.left = toCssPx(x);
       this.style.right = toCssPx(x);
       this.style.top = toCssPx(y);
     },
 
-    onBlur_: function(e) {
+    /** @private */
+    onBlur_: function() {
       this.classList.remove('click-focus');
       this.appContents_.classList.remove('suppress-active');
     },
 
     /**
      * Invoked when an app is clicked.
      * @param {Event} e The click/auxclick event.
      * @private
      */
     onClick_: function(e) {
@@ skipping 23 matching lines @@
       }
     },
 
     /**
      * Adds a node to the list of targets that will launch the app. This list
      * is also used in onMousedown to determine whether the app contents should
      * be shown as active (if we don't do this, then clicking anywhere in
      * appContents, even a part that is outside the ideally clickable region,
      * will cause the app icon to look active).
      * @param {HTMLElement} node The node that should be clickable.
+     * @private
      */
     addLaunchClickTarget_: function(node) {
       node.classList.add('launch-click-target');
       node.addEventListener('click', this.onClick_.bind(this));
       node.addEventListener('auxclick', this.onClick_.bind(this));
     },
 
     /**
      * Handler for mousedown on the App. Adds a class that allows us to
      * not display as :active for right clicks (specifically, don't pulse on
      * these occasions). Also, we don't pulse for clicks that aren't within the
      * clickable regions.
      * @param {Event} e The mousedown event.
+     * @private
      */
     onMousedown_: function(e) {
       // If the current platform uses middle click to autoscroll and this
       // mousedown isn't handled, onClick_() will never fire. crbug.com/142939
       if (e.button == 1)
         e.preventDefault();
 
       if (e.button == 2 ||
           !findAncestorByClass(/** @type {Element} */(e.target),
                                'launch-click-target')) {
@@ skipping 17 matching lines @@
       this.loadIcon();
     },
 
     /**
      * The data and preferences for this app.
      * @type {Object}
      */
     set appData(data) { this.appData_ = data; },
     get appData() { return this.appData_; },
 
+    /** @type {string} */
     get appId() { return this.appData_.id; },
 
     /**
      * Returns a pointer to the context menu for this app. All apps share the
      * singleton AppContextMenu. This function is called by the
      * ContextMenuHandler in response to the 'contextmenu' event.
      * @type {cr.ui.Menu}
      */
     get contextMenu() {
       var menu = AppContextMenu.getInstance();
@@ skipping 100 matching lines @@
       }
 
       this.addTileAt(new App(appData), index, animate);
     },
 
     /**
      * Handler for 'cardselected' event, fired when |this| is selected. The
      * first time this is called, we load all the app icons.
      * @private
      */
-    onCardSelected_: function(e) {
+    onCardSelected_: function() {
       var apps = this.querySelectorAll('.app.icon-loading');
       for (var i = 0; i < apps.length; i++) {
         apps[i].loadIcon();
       }
     },
 
     /**
      * Handler for tile additions to this page.
      * @param {Event} e The tilePage:tile_added event.
+     * @private
      */
     onTileAdded_: function(e) {
       assert(e.currentTarget == this);
       assert(e.addedTile.firstChild instanceof App);
       if (this.classList.contains('selected-card'))
         e.addedTile.firstChild.loadIcon();
     },
 
     /**
      * A handler for when the apps page is scrolled (then we need to reposition
      * the bubbles.
      * @private
      */
-    onScroll_: function(e) {
+    onScroll_: function() {
       if (!this.selected)
         return;
       for (var i = 0; i < this.tileElements_.length; i++) {
         var app = this.tileElements_[i].firstChild;
         assert(app instanceof App);
       }
     },
 
     /** @override */
     doDragOver: function(e) {
@@ skipping 128 matching lines @@
     chrome.send('launchApp', [appId, APP_LAUNCH.NTP_APP_RE_ENABLE]);
   }
 
   return {
     APP_LAUNCH: APP_LAUNCH,
     App: App,
     AppsPage: AppsPage,
     launchAppAfterEnable: launchAppAfterEnable,
   };
 });