Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 2891873002: ntp4: Fix some closure compiler annotations in apps_page.js (Closed)

Created:
3 years, 7 months ago by Dan Beam
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-ntp_chromium.org, pedrosimonetti+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ntp4: Fix some closure compiler annotations in apps_page.js R=dpapad@chromium.org BUG=723928 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2891873002 Cr-Commit-Position: refs/heads/master@{#472857} Committed: https://chromium.googlesource.com/chromium/src/+/e4cc35c01c052ed93ac46727085ef52d98a0217f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M chrome/browser/resources/ntp4/apps_page.js View 12 chunks +32 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Dan Beam
3 years, 7 months ago (2017-05-18 03:00:12 UTC) #2
dpapad
LGTM
3 years, 7 months ago (2017-05-18 15:57:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891873002/1
3 years, 7 months ago (2017-05-18 17:20:53 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 17:26:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e4cc35c01c052ed93ac46727085e...

Powered by Google App Engine
This is Rietveld 408576698