Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2891863002:
[ObjC ARC] Converts ios/testing:ocmock_support_unittest to ARC. (Closed)
Description[ObjC ARC] Converts ios/testing:ocmock_support_unittest to ARC.
Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
Review-Url: https://codereview.chromium.org/2891863002
Cr-Commit-Position: refs/heads/master@{#479505}
Committed: https://chromium.googlesource.com/chromium/src/+/11259e450d6002293271d60949681a1d99d7422b
Patch Set 1 #Patch Set 2 : Fix auto arc script errors #
Total comments: 1
Messages
Total messages: 28 (20 generated)
The CQ bit was checked by liaoyuke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by liaoyuke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by liaoyuke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
liaoyuke@chromium.org changed reviewers: + stkhapugin@chromium.org
Hey Stepan, PTAL. Thank you very much! https://codereview.chromium.org/2891863002/diff/40001/ios/testing/ocmock_comp... File ios/testing/ocmock_complex_type_helper_unittest.mm (right): https://codereview.chromium.org/2891863002/diff/40001/ios/testing/ocmock_comp... ios/testing/ocmock_complex_type_helper_unittest.mm:55: OCMockObject* protocol_mock = this temporary variable helps with formatting.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by stkhapugin@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
liaoyuke@chromium.org changed reviewers: + rohitrao@chromium.org
Hi Rohit, Could you please do a quick owner's approval? Thanks!
lgtm
The CQ bit was checked by liaoyuke@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497474380686290,
"parent_rev": "5855a909f84c52234482842673e4ba00421039ff", "commit_rev":
"11259e450d6002293271d60949681a1d99d7422b"}
Message was sent while issue was closed.
Description was changed from ========== [ObjC ARC] Converts ios/testing:ocmock_support_unittest to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts ios/testing:ocmock_support_unittest to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2891863002 Cr-Commit-Position: refs/heads/master@{#479505} Committed: https://chromium.googlesource.com/chromium/src/+/11259e450d6002293271d6094968... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/11259e450d6002293271d6094968... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
