Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2891853004: [string] Deduplicate in String.p.toLowerCase (Closed)

Created:
3 years, 7 months ago by jgruber
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[string] Deduplicate in String.p.toLowerCase Restore original behavior in that strings are deduplicated in lower-case conversion (i.e. if the string is already lower-case, the original string is returned). BUG=v8:6353, v8:6412 Review-Url: https://codereview.chromium.org/2891853004 Cr-Commit-Position: refs/heads/master@{#45391} Committed: https://chromium.googlesource.com/v8/v8/+/17512c3799d689b4679ee7a2bd8e5c8f3bf28ddf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M src/builtins/builtins-intl-gen.cc View 1 chunk +16 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jgruber
3 years, 7 months ago (2017-05-18 08:39:51 UTC) #4
Benedikt Meurer
lgtm
3 years, 7 months ago (2017-05-18 08:43:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891853004/1
3 years, 7 months ago (2017-05-18 08:49:26 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 08:51:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/17512c3799d689b4679ee7a2bd8e5c8f3bf...

Powered by Google App Engine
This is Rietveld 408576698