Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2891853002: [ObjC ARC] Converts ios/chrome/app:tests_fake_hook to ARC. (Closed)

Created:
3 years, 7 months ago by liaoyuke
Modified:
3 years, 7 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/app:tests_fake_hook to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2891853002 Cr-Commit-Position: refs/heads/master@{#472933} Committed: https://chromium.googlesource.com/chromium/src/+/f88f6d0e6225a933e189cf4c14f51084d889c6f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ios/chrome/app/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/app/tests_fake_hook.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
liaoyuke
Hey Rohit, PTAL. Thank you very much!
3 years, 7 months ago (2017-05-18 18:14:37 UTC) #6
rohitrao (ping after 24h)
lgtm
3 years, 7 months ago (2017-05-18 20:47:27 UTC) #7
liaoyuke
On 2017/05/18 20:47:27, rohitrao (ping after 24h) wrote: > lgtm Thank you for the quick ...
3 years, 7 months ago (2017-05-18 21:11:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891853002/1
3 years, 7 months ago (2017-05-18 21:12:29 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 21:21:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f88f6d0e6225a933e189cf4c14f5...

Powered by Google App Engine
This is Rietveld 408576698