Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 2891803002: Revert of Backfill some UI tests. (Closed)

Created:
3 years, 7 months ago by Bret
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, groby+bubble_chromium.org, tfarina, jam, darin-cc_chromium.org, hcarmona+bubble_chromium.org, rouslan+bubble_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Backfill some UI tests. (patchset #9 id:160001 of https://codereview.chromium.org/2861533003/ ) Reason for revert: Caused compile failure Original issue's description: > Backfill some UI tests. > > * Added a test for DialogClientView's button layout. > * Added a test for non client hit results in BubbleFrameView. > * Added a test for ValidationMessageBubbleView's anchor rect at HighDPI. > > BUG=702196, 680019 > > Review-Url: https://codereview.chromium.org/2861533003 > Cr-Commit-Position: refs/heads/master@{#472550} > Committed: https://chromium.googlesource.com/chromium/src/+/819580022f1d2c8dc1eaa4d8614e765a55f95a4b TBR=sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=702196, 680019 Review-Url: https://codereview.chromium.org/2891803002 Cr-Commit-Position: refs/heads/master@{#472554} Committed: https://chromium.googlesource.com/chromium/src/+/d77878b9c9f4f4db96a21e0974843a7e8cd77b24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -116 lines) Patch
D chrome/browser/ui/views/validation_message_bubble_view_unittest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_render_view_host.h View 4 chunks +2 lines, -10 lines 0 comments Download
M content/test/test_render_view_host.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M ui/views/window/dialog_client_view_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M ui/views/window/dialog_delegate_unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Bret
Created Revert of Backfill some UI tests.
3 years, 7 months ago (2017-05-17 20:37:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891803002/1
3 years, 7 months ago (2017-05-17 20:39:36 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 20:40:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d77878b9c9f4f4db96a21e097484...

Powered by Google App Engine
This is Rietveld 408576698