Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2891773003: [Android] Don't increase app menu height when at bottom pre-N (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Don't increase app menu height when at bottom pre-N When the app menu is at the bottom of the screen, do not increase the height to include the anchor view pre-N. This was causing the app menu to get cut-off in landscape mode. Long term we should stop using ListPopupWindow. BUG=722105 Review-Url: https://codereview.chromium.org/2891773003 Cr-Commit-Position: refs/heads/master@{#472474} Committed: https://chromium.googlesource.com/chromium/src/+/0feff5f517e63ec7ecf04192464c61c57f9e1686

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Theresa
ptal
3 years, 7 months ago (2017-05-17 15:41:55 UTC) #4
Ted C
lgtm
3 years, 7 months ago (2017-05-17 15:46:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891773003/1
3 years, 7 months ago (2017-05-17 15:49:09 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 16:31:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0feff5f517e63ec7ecf04192464c...

Powered by Google App Engine
This is Rietveld 408576698