Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2891743003: Enable interpolation of CSS property font-variation-settings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 days, 7 hours ago by alancutter
Modified:
2 days, 21 hours ago
Reviewers:
drott, Eric Willigers
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, chromium-reviews, dglazkov+blink, rjwright, rwlbuis, shans, drott
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tests #

Patch Set 3 : lint #

Patch Set 4 : undo rebaseline #

Total comments: 2

Patch Set 5 : updatetest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+601 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/animations/composition/font-variation-settings-composition.html View 1 2 3 4 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/interpolation/font-variation-settings-interpolation.html View 1 chunk +113 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js View 1 2 3 4 chunks +13 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/responsive/font-variation-settings-responsive.html View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/CSSFontVariationSettingsInterpolationType.h View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/CSSFontVariationSettingsInterpolationType.cpp View 1 chunk +213 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/animatable/AnimatableFontVariationSettings.h View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/animatable/AnimatableFontVariationSettings.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValue.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp View 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 24 (12 generated)
alancutter
3 days, 12 hours ago (2017-05-19 03:34:08 UTC) #2
Eric Willigers
We should link to the spec that describes the property an animatable: https://drafts.csswg.org/css-fonts-4/#low-level-font-variation-settings-control-the-font-variation-settings-property
3 days, 10 hours ago (2017-05-19 04:59:37 UTC) #5
Eric Willigers
Please add spec link. https://codereview.chromium.org/2891743003/diff/60001/third_party/WebKit/LayoutTests/animations/composition/font-variation-settings-composition.html File third_party/WebKit/LayoutTests/animations/composition/font-variation-settings-composition.html (right): https://codereview.chromium.org/2891743003/diff/60001/third_party/WebKit/LayoutTests/animations/composition/font-variation-settings-composition.html#newcode65 third_party/WebKit/LayoutTests/animations/composition/font-variation-settings-composition.html:65: {at: 0, is: "'aaaa' 150, ...
3 days, 10 hours ago (2017-05-19 05:33:28 UTC) #6
alancutter
Added spec link. https://codereview.chromium.org/2891743003/diff/60001/third_party/WebKit/LayoutTests/animations/composition/font-variation-settings-composition.html File third_party/WebKit/LayoutTests/animations/composition/font-variation-settings-composition.html (right): https://codereview.chromium.org/2891743003/diff/60001/third_party/WebKit/LayoutTests/animations/composition/font-variation-settings-composition.html#newcode65 third_party/WebKit/LayoutTests/animations/composition/font-variation-settings-composition.html:65: {at: 0, is: "'aaaa' 150, 'bbbb' ...
3 days, 8 hours ago (2017-05-19 06:59:55 UTC) #8
Eric Willigers
lgtm
3 days, 8 hours ago (2017-05-19 07:22:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891743003/80001
3 days, 8 hours ago (2017-05-19 07:28:32 UTC) #11
drott
Non-owner LGTM, awesome!
3 days, 7 hours ago (2017-05-19 08:21:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/449633)
3 days, 5 hours ago (2017-05-19 09:47:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891743003/80001
3 days, 5 hours ago (2017-05-19 10:33:31 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/449743)
3 days ago (2017-05-19 14:46:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891743003/80001
2 days, 23 hours ago (2017-05-19 15:40:33 UTC) #21
commit-bot: I haz the power
2 days, 21 hours ago (2017-05-19 17:59:44 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/833939114f317ca1b5c53f2c832a...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06