third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor.html - Issue 2891723002: Do not create child node for Option constructor with no arguments/undefined text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor.html

Issue 2891723002: Do not create child node for Option constructor with no arguments/undefined text (Closed)

Patch Set: Rebased and added IsEmpty check Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor.html

diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor.html b/third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor.html

index 51fc3e4402ea2b44af6aae1e3e65dc7b8278041b..8e586de6987a19f53fb1fa077b3a5c16815dac5d 100644

--- a/third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor.html

+++ b/third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor.html

@@ -91,6 +91,16 @@

}, "Option constructor treats undefined text and value correctly");

test(() => {

+ const option = new Option("", "");

+ assert_false(option.hasChildNodes());

+ assert_true(option.hasAttribute("value"));

+ assert_equals(option.textContent, "");

+ assert_equals(option.value, "");

+ }, "Option constructor treats empty text and value correctly");

+ test(() => {

const option = new Option("text", "value", 0, "");

assert_false(option.hasAttribute("selected"));