third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor-expected.txt - Issue 2891723002: Do not create child node for Option constructor with no arguments/undefined text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor-expected.txt

Issue 2891723002: Do not create child node for Option constructor with no arguments/undefined text (Closed)

Patch Set: Rebased and added IsEmpty check Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor.html ('k') | third_party/WebKit/Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor-expected.txt

diff --git a/third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor-expected.txt b/third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor-expected.txt

deleted file mode 100644

index bf012cba5a6561a8ea4eb4f9976b0b34dd052039..0000000000000000000000000000000000000000

--- a/third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-option-element/option-element-constructor-expected.txt

+++ /dev/null

@@ -1,12 +0,0 @@

-This is a testharness.js-based test.

-FAIL Option constructor with no arguments assert_false: expected false got true

-PASS Option constructor with falsy arguments

-PASS Option constructor creates HTMLOptionElement with specified text and value

-PASS Option constructor handles selectedness correctly when specified with defaultSelected only

-PASS Option constructor handles selectedness correctly, even when incongruous with defaultSelected

-FAIL Option constructor treats undefined text and value correctly assert_false: expected false got true

-PASS Option constructor treats falsy selected and defaultSelected correctly

-PASS Option constructor treats truthy selected and defaultSelected correctly

-PASS Option constructor does not set dirtiness (so, manipulating the selected content attribute still updates the selected IDL attribute)

-Harness: the test ran to completion.