Do not create child node for Option constructor with no arguments/undefined text

third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

Index: third_party/WebKit/Source/core/html/HTMLOptionElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp b/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp
index 218ea266c83254a97530a771d2684d4d49b9f96d..7c0eb3c87b142b662cbde98b03eec9f0bacb676c 100644
--- a/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp
@@ -72,8 +72,8 @@ HTMLOptionElement* HTMLOptionElement::CreateForJSConstructor(
     ExceptionState& exception_state) {
   HTMLOptionElement* element = new HTMLOptionElement(document);
   element->EnsureUserAgentShadowRoot();
-  element->AppendChild(Text::Create(document, data.IsNull() ? "" : data),
-                       exception_state);
+  if (!data.IsNull())

[foolip, 2017/05/17 11:23:12]

The spec says "If text is not the empty string, then append to option a new Text
node whose data is text."

This only handles the argument being omitted, not when it is the empty string,
so it should still be possible to write a per-spec test that fails.

I think that the right thing here is to:
1. Import the test from wpt (or wait for an automatic import)
2. Use data.IsEmpty() here and in the same CL update the test to cover that
case.

[Shanmuga Pandi, 2017/05/17 11:29:35]

I understood. I will wait for the automatic import. I am not sure about how to
import test from wpt.

+    element->AppendChild(Text::Create(document, data), exception_state);
   if (exception_state.HadException())
     return nullptr;