Do not create child node for Option constructor with no arguments/undefined text

third_party/WebKit/Source/core/html/HTMLOptionElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2011 Motorola Mobility, Inc.  All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 54 matching lines @@
 
 HTMLOptionElement* HTMLOptionElement::CreateForJSConstructor(
     Document& document,
     const String& data,
     const AtomicString& value,
     bool default_selected,
     bool selected,
     ExceptionState& exception_state) {
   HTMLOptionElement* element = new HTMLOptionElement(document);
   element->EnsureUserAgentShadowRoot();
-  element->AppendChild(Text::Create(document, data.IsNull() ? "" : data),
-                       exception_state);
+  if (!data.IsNull())

[foolip, 2017/05/17 11:23:12]

The spec says "If text is not the empty string, then append to option a new Text
node whose data is text."

This only handles the argument being omitted, not when it is the empty string,
so it should still be possible to write a per-spec test that fails.

I think that the right thing here is to:
1. Import the test from wpt (or wait for an automatic import)
2. Use data.IsEmpty() here and in the same CL update the test to cover that
case.

[Shanmuga Pandi, 2017/05/17 11:29:35]

I understood. I will wait for the automatic import. I am not sure about how to
import test from wpt.

+    element->AppendChild(Text::Create(document, data), exception_state);
   if (exception_state.HadException())
     return nullptr;
 
   if (!value.IsNull())
     element->setValue(value);
   if (default_selected)
     element->setAttribute(selectedAttr, g_empty_atom);
   element->SetSelected(selected);
 
   return element;
@@ skipping 346 matching lines @@
 }
 
 String HTMLOptionElement::innerText() {
   // A workaround for crbug.com/424578. We add ShadowRoot to an OPTION, but
   // innerText behavior for Shadow DOM is unclear.  We just return the same
   // string before adding ShadowRoot.
   return textContent();
 }
 
 }  // namespace blink