Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 2891713002: Cleanup: Make CheckClassId instruction more general so it (Closed)
Patch Set: Feedback from Martin Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_x64.cc
diff --git a/runtime/vm/flow_graph_compiler_x64.cc b/runtime/vm/flow_graph_compiler_x64.cc
index b0d6f72e952b5391d24e98c88d822cde2f3a0348..35d199f45fef003999332b8b7b0c24dc4c7bf48c 100644
--- a/runtime/vm/flow_graph_compiler_x64.cc
+++ b/runtime/vm/flow_graph_compiler_x64.cc
@@ -1477,13 +1477,13 @@ int FlowGraphCompiler::EmitTestAndCallCheckCid(Label* next_label,
int bias) {
intptr_t cid_start = range.cid_start;
intptr_t cid_end = range.cid_end;
- if (cid_start == cid_end) {
+ if (range.IsSingleCid()) {
__ cmpl(RDI, Immediate(cid_start - bias));
__ j(NOT_EQUAL, next_label);
} else {
__ addl(RDI, Immediate(bias - cid_start));
bias = cid_start;
- __ cmpl(RDI, Immediate(cid_end - cid_start));
+ __ cmpl(RDI, Immediate(range.Extent()));
__ j(ABOVE, next_label); // Unsigned higher.
}
return bias;
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698