runtime/vm/flow_graph_compiler_mips.cc - Issue 2891713002: Cleanup: Make CheckClassId instruction more general so it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 2891713002: Cleanup: Make CheckClassId instruction more general so it (Closed)

Patch Set: Feedback from Martin Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_mips.cc

diff --git a/runtime/vm/flow_graph_compiler_mips.cc b/runtime/vm/flow_graph_compiler_mips.cc

index f432acdeedf55f79e09bad7cef665230d36ba601..a8e408e31d93e40fc30e09c45b25aed365a26485 100644

--- a/runtime/vm/flow_graph_compiler_mips.cc

+++ b/runtime/vm/flow_graph_compiler_mips.cc

@@ -1558,7 +1558,7 @@ int FlowGraphCompiler::EmitTestAndCallCheckCid(Label* next_label,

int bias) {

intptr_t cid_start = range.cid_start;

intptr_t cid_end = range.cid_end;

- if (cid_start == cid_end) {

+ if (range.IsSingleCid()) {

__ BranchNotEqual(T2, Immediate(cid_start - bias), next_label);

} else {

__ AddImmediate(T2, T2, bias - cid_start);

« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »