ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm - Issue 2891653003: [omnibox] Break out SetCaretPos() method and enhance browser test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm

Issue 2891653003: [omnibox] Break out SetCaretPos() method and enhance browser test (Closed)

Patch Set: Responses Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm

diff --git a/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm b/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm

index 41e447d6a6bc53aaf1d55013eee0c4f300899698..5a4a4c6da958abb5699b6aa96aa537baa7e43eba 100644

--- a/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm

+++ b/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm

@@ -242,6 +242,8 @@ void OmniboxViewIOS::SetWindowTextAndCaretPos(const base::string16& text,

model()->OnChanged();

}

+void OmniboxViewIOS::SetCaretPos(size_t caret_pos) {}

void OmniboxViewIOS::RevertAll() {

ignore_popup_updates_ = true;

OmniboxView::RevertAll();