ios/chrome/browser/ui/omnibox/omnibox_view_ios.h - Issue 2891653003: [omnibox] Break out SetCaretPos() method and enhance browser test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/omnibox/omnibox_view_ios.h

Issue 2891653003: [omnibox] Break out SetCaretPos() method and enhance browser test (Closed)

Patch Set: Responses Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/omnibox/omnibox_view_ios.h

diff --git a/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h b/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h

index f0768d3347564c5d14d07c10452af9c3b7693743..55c199428cb5b4505146ae0850c2a3a5d1b6c636 100644

--- a/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h

+++ b/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h

@@ -56,6 +56,7 @@ class OmniboxViewIOS : public OmniboxView {

size_t caret_pos,

bool update_popup,

bool notify_text_changed) override;

+ void SetCaretPos(size_t caret_pos) override;

void RevertAll() override;

void UpdatePopup() override;

void OnTemporaryTextMaybeChanged(const base::string16& display_text,