[omnibox] Break out SetCaretPos() method and enhance browser test

components/omnibox/browser/omnibox_edit_model.cc

Index: components/omnibox/browser/omnibox_edit_model.cc
diff --git a/components/omnibox/browser/omnibox_edit_model.cc b/components/omnibox/browser/omnibox_edit_model.cc
index e9fd507c1c66e3999e1de6bffcfd1fd5b7fe8ed6..482d7a8cc0547edce14612464cdcb48378755512 100644
--- a/components/omnibox/browser/omnibox_edit_model.cc
+++ b/components/omnibox/browser/omnibox_edit_model.cc
@@ -372,9 +372,9 @@ void OmniboxEditModel::Revert() {
   has_temporary_text_ = false;
   size_t start, end;
   view_->GetSelectionBounds(&start, &end);
-  view_->SetWindowTextAndCaretPos(permanent_text_, 0, false, false);
-  view_->SetWindowTextAndCaretPos(
-      permanent_text_, std::min(permanent_text_.length(), start), false, true);
+  // First home cursor, so view of text is scrolled to left, then correct it.

[Peter Kasting, 2017/05/25 23:19:19]

Nit: This helps, but I'd probably expand the comment further to clarify what
would happen if you didn't do this.  (The scrolling behavior when the cursor
position is set is not immediately obvious.)

[Kevin Bailey, 2017/05/26 13:58:05]

Done.

+  view_->SetWindowTextAndCaretPos(permanent_text_, 0, false, true);
+  view_->SetCaretPos(std::min(permanent_text_.length(), start));
   client_->OnRevert();
 }