[omnibox] Break out SetCaretPos() method and enhance browser test

components/omnibox/browser/omnibox_edit_model.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/browser/omnibox_edit_model.h"
 
 #include <algorithm>
 #include <string>
 #include <utility>
 
@@ skipping 354 matching lines @@
 void OmniboxEditModel::Revert() {
   SetInputInProgress(false);
   input_.Clear();
   paste_state_ = NONE;
   InternalSetUserText(base::string16());
   keyword_.clear();
   is_keyword_hint_ = false;
   has_temporary_text_ = false;
   size_t start, end;
   view_->GetSelectionBounds(&start, &end);
-  view_->SetWindowTextAndCaretPos(permanent_text_, 0, false, false);
-  view_->SetWindowTextAndCaretPos(
-      permanent_text_, std::min(permanent_text_.length(), start), false, true);
+  // First home cursor, so view of text is scrolled to left, then correct it.

[Peter Kasting, 2017/05/25 23:19:19]

Nit: This helps, but I'd probably expand the comment further to clarify what
would happen if you didn't do this.  (The scrolling behavior when the cursor
position is set is not immediately obvious.)

[Kevin Bailey, 2017/05/26 13:58:05]

Done.

+  view_->SetWindowTextAndCaretPos(permanent_text_, 0, false, true);
+  view_->SetCaretPos(std::min(permanent_text_.length(), start));
   client_->OnRevert();
 }
 
 void OmniboxEditModel::StartAutocomplete(bool has_selected_text,
                                          bool prevent_inline_autocomplete) {
   const base::string16 input_text = MaybePrependKeyword(user_text_);
 
   size_t start, cursor_position;
   view_->GetSelectionBounds(&start, &cursor_position);
 
@@ skipping 1000 matching lines @@
   // Update state and notify view if the omnibox has focus and the caret
   // visibility changed.
   const bool was_caret_visible = is_caret_visible();
   focus_state_ = state;
   if (focus_state_ != OMNIBOX_FOCUS_NONE &&
       is_caret_visible() != was_caret_visible)
     view_->ApplyCaretVisibility();
 
   client_->OnFocusChanged(focus_state_, reason);
 }