Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 289163004: cc: fix another data race in RenderingStatsInstrumentation. (Closed)

Created:
6 years, 7 months ago by ernstm
Modified:
6 years, 7 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: fix another data race in RenderingStatsInstrumentation. Access to the stats was not protected by a lock. Fix by returning a copy to the stats and locking while making the copy. R=enne@chromium.org BUG=370244 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M cc/debug/rendering_stats_instrumentation.h View 1 chunk +7 lines, -8 lines 0 comments Download
M cc/debug/rendering_stats_instrumentation.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ernstm
PTAL
6 years, 7 months ago (2014-05-16 23:19:45 UTC) #1
enne (OOO)
lgtm
6 years, 7 months ago (2014-05-19 17:24:45 UTC) #2
ernstm
The CQ bit was checked by ernstm@chromium.org
6 years, 7 months ago (2014-05-19 21:56:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/289163004/1
6 years, 7 months ago (2014-05-19 21:57:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 01:20:26 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 04:02:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/17628)
6 years, 7 months ago (2014-05-20 04:02:36 UTC) #7
ernstm
The CQ bit was checked by ernstm@chromium.org
6 years, 7 months ago (2014-05-20 04:32:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/289163004/1
6 years, 7 months ago (2014-05-20 04:33:09 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 15:17:28 UTC) #10
Message was sent while issue was closed.
Change committed as 271646

Powered by Google App Engine
This is Rietveld 408576698