Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Side by Side Diff: cc/debug/rendering_stats_instrumentation.h

Issue 289163004: cc: fix another data race in RenderingStatsInstrumentation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | cc/debug/rendering_stats_instrumentation.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_DEBUG_RENDERING_STATS_INSTRUMENTATION_H_ 5 #ifndef CC_DEBUG_RENDERING_STATS_INSTRUMENTATION_H_
6 #define CC_DEBUG_RENDERING_STATS_INSTRUMENTATION_H_ 6 #define CC_DEBUG_RENDERING_STATS_INSTRUMENTATION_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/synchronization/lock.h" 9 #include "base/synchronization/lock.h"
10 #include "cc/debug/rendering_stats.h" 10 #include "cc/debug/rendering_stats.h"
11 11
12 namespace cc { 12 namespace cc {
13 13
14 // RenderingStatsInstrumentation is shared among threads and manages conditional 14 // RenderingStatsInstrumentation is shared among threads and manages conditional
15 // recording of rendering stats into a private RenderingStats instance. 15 // recording of rendering stats into a private RenderingStats instance.
16 class CC_EXPORT RenderingStatsInstrumentation { 16 class CC_EXPORT RenderingStatsInstrumentation {
17 public: 17 public:
18 static scoped_ptr<RenderingStatsInstrumentation> Create(); 18 static scoped_ptr<RenderingStatsInstrumentation> Create();
19 virtual ~RenderingStatsInstrumentation(); 19 virtual ~RenderingStatsInstrumentation();
20 20
21 // Return current main thread rendering stats. 21 // Return copy of current main thread rendering stats.
22 const MainThreadRenderingStats& main_thread_rendering_stats() { 22 MainThreadRenderingStats main_thread_rendering_stats();
23 return main_stats_; 23
24 } 24 // Return copy of current impl thread rendering stats.
25 // Return current impl thread rendering stats. 25 ImplThreadRenderingStats impl_thread_rendering_stats();
26 const ImplThreadRenderingStats& impl_thread_rendering_stats() { 26
27 return impl_stats_;
28 }
29 // Return the accumulated, combined rendering stats. 27 // Return the accumulated, combined rendering stats.
30 RenderingStats GetRenderingStats(); 28 RenderingStats GetRenderingStats();
31 29
32 // Add current main thread rendering stats to accumulator and 30 // Add current main thread rendering stats to accumulator and
33 // clear current stats. 31 // clear current stats.
34 void AccumulateAndClearMainThreadStats(); 32 void AccumulateAndClearMainThreadStats();
33
35 // Add current impl thread rendering stats to accumulator and 34 // Add current impl thread rendering stats to accumulator and
36 // clear current stats. 35 // clear current stats.
37 void AccumulateAndClearImplThreadStats(); 36 void AccumulateAndClearImplThreadStats();
38 37
39 // Read and write access to the record_rendering_stats_ flag is not locked to 38 // Read and write access to the record_rendering_stats_ flag is not locked to
40 // improve performance. The flag is commonly turned off and hardly changes 39 // improve performance. The flag is commonly turned off and hardly changes
41 // it's value during runtime. 40 // it's value during runtime.
42 bool record_rendering_stats() const { return record_rendering_stats_; } 41 bool record_rendering_stats() const { return record_rendering_stats_; }
43 void set_record_rendering_stats(bool record_rendering_stats) { 42 void set_record_rendering_stats(bool record_rendering_stats) {
44 if (record_rendering_stats_ != record_rendering_stats) 43 if (record_rendering_stats_ != record_rendering_stats)
(...skipping 24 matching lines...) Expand all
69 bool record_rendering_stats_; 68 bool record_rendering_stats_;
70 69
71 base::Lock lock_; 70 base::Lock lock_;
72 71
73 DISALLOW_COPY_AND_ASSIGN(RenderingStatsInstrumentation); 72 DISALLOW_COPY_AND_ASSIGN(RenderingStatsInstrumentation);
74 }; 73 };
75 74
76 } // namespace cc 75 } // namespace cc
77 76
78 #endif // CC_DEBUG_RENDERING_STATS_INSTRUMENTATION_H_ 77 #endif // CC_DEBUG_RENDERING_STATS_INSTRUMENTATION_H_
OLDNEW
« no previous file with comments | « no previous file | cc/debug/rendering_stats_instrumentation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698