Issue 289163003: Fix build with gcc 4.8 and C++11 support enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 289163003: Fix build with gcc 4.8 and C++11 support enabled (Closed)

Created:
6 years, 7 months ago by Inactive

Modified:
6 years, 7 months ago

Reviewers:
Nico, eseidel

CC:
blink-reviews, blink-reviews-html_chromium.org, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-rendering, jchaffraix+rendering, pdr., rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix build with gcc 4.8 and C++11 support enabled Fix build with gcc 4.8 and C++11 support enabled. The build was failing because of a naming conflict between CheckedState enum in wtf/CheckedArithmetic.h and the CheckedState value in ThemeTypes.h's ControlState enum. This CL renames ThemeTypes.h's ControlState enum values to end with "ControlState" instead of "State" to reduce the risk of naming conflicts. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174231

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -43 lines)			Patch
M	Source/core/dom/ContainerNode.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLFormControlElement.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLInputElement.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLOptionElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderTheme.cpp	View	2 chunks	+12 lines, -12 lines	0 comments	Download
M	Source/core/rendering/RenderThemeChromiumDefault.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/ThemeTypes.h	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	Source/platform/mac/ThemeMac.mm	View	4 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/289163003/1

6 years, 7 months ago (2014-05-16 20:19:33 UTC) #3

Message was sent while issue was closed.

Change committed as 174231

Expand Messages | Collapse Messages