Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2891623002: Disable crashing unittests in background offliner. (Closed)

Created:
3 years, 7 months ago by Donn Denman
Modified:
3 years, 7 months ago
Reviewers:
chili
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable crashing unittests in background offliner. Two unit tests are crashing a lot on Android, disabling those tests in background_loader_offliner_unittest.cc for Android only. BUG=722556 TBR=dewittj@chromium.org Review-Url: https://codereview.chromium.org/2891623002 Cr-Commit-Position: refs/heads/master@{#472286} Committed: https://chromium.googlesource.com/chromium/src/+/c4ed92c85ad786af4f04f9934c1c994236403d01

Patch Set 1 #

Patch Set 2 : Rebased, which handles the file moving outside the /android path. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/browser/offline_pages/background_loader_offliner_unittest.cc View 1 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Donn Denman
Cathy, PTAL. Thanks!
3 years, 7 months ago (2017-05-16 23:33:11 UTC) #3
chili
lgtm
3 years, 7 months ago (2017-05-17 00:02:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891623002/20001
3 years, 7 months ago (2017-05-17 02:05:37 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 02:12:45 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c4ed92c85ad786af4f04f9934c1c...

Powered by Google App Engine
This is Rietveld 408576698